feat: ASC-00000 - create livestream #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ptchayap wants to merge 30 commits into native-sprint from feat/asc-00000-create-livestream

Collaborator

ptchayap commented Mar 26, 2024

No description provided.

ptchayap and others added 18 commits

February 28, 2024 23:46


          feat: add create livestream page

a15ec56


          feat: add creating livestream post

f3b13c4


          fix: wrong state conditioning

551e99f


          feat: create post and connect to livestream server

4df3a81


          fix: use node-mediaclient instead of api.video

259b9e5


          feat: add camera permission to android

34c3f3c


          feat: add ending stream

f4029d0


          feat: add empty title alert

1ed1320


          feat: remove api.video

7be3c71


          fix: isEnding false after end livestream

af7c810


          fix: remove all config in provider

538a149


          fix: remove unused config

0a9ca6c


          fix: description cannot be empty

5c60eb0


          feat: add page after stop streaming

835f0c8


          Add files via upload

d742c72


          Update README.md

367c02f


          fix: title description not show in post

5dd8b25


          feat: change compile version to 34 to support the library

18af09c

ptchayap requested a review from NaingAmity

March 26, 2024 04:05


          fix: mentionees undefined

6d443c5

frankent reviewed

View reviewed changes

frankent left a comment

Question krub

src/components/PostTypeChoiceModal/PostTypeChoiceModal.tsx Outdated Show resolved Hide resolved

src/components/PostTypeChoiceModal/PostTypeChoiceModal.tsx Show resolved Hide resolved

src/hooks/useImagePicker.ts Show resolved Hide resolved

src/screens/CreateLivestream/index.tsx Show resolved Hide resolved

ptchayap commented

View reviewed changes

example/android/app/src/main/AndroidManifest.xml Show resolved Hide resolved

ptchayap commented

View reviewed changes

example/android/build.gradle Show resolved Hide resolved

ptchayap commented

View reviewed changes

example/ios/Podfile Outdated Show resolved Hide resolved

ptchayap commented

View reviewed changes

example/package.json Outdated Show resolved Hide resolved

ptchayap commented

View reviewed changes

src/components/CancelButton/index.tsx Outdated Show resolved Hide resolved

ptchayap commented

View reviewed changes

src/components/CloseButton/index.tsx Outdated Show resolved Hide resolved

ptchayap commented

View reviewed changes

src/screens/CreateLivestream/index.tsx Outdated Show resolved Hide resolved

NaingAmity and others added 2 commits

March 26, 2024 16:01


          fix: set initial text

a594ae5


          fix: pr comment

4d0a394

ptchayap added 9 commits

March 26, 2024 20:47


          fix: change to use bottomSheet

c28bb02


          fix: to use useNavigation

3b8f6c1


          fix: to use minWidth

3a5fa1f


          fix: remove double TouchableOpacity

6c1b05b


          fix: remove change on podFile

23893de


          merge native branch

fd9260e


          fix: dependencies

c74380b


          fix: netInfo dependency

f4b7278


          fix: param types

4baa3ac

NaingAmity commented Mar 28, 2024

LGTM !!

NaingAmity approved these changes

View reviewed changes

ptchayap changed the base branch from native to native-sprint

March 29, 2024 07:09

ptchayap closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet