Keep existing device type #803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
The device type in the collector should always take precedence over smartctl info results. |
Author
|
Exactly. That's the reason why I removed that line, as it overwrote the collector's device type with the smartctl info results. |
thomashilzendegen
force-pushed
the
fix/device-type-override
branch
from
61641d2 to
76e4de8
Compare
thomashilzendegen
force-pushed
the
fix/device-type-override
branch
from
76e4de8 to
4bf4b5f
Compare
Starosdev
added a commit
to Starosdev/scrutiny
that referenced
this pull request
Nov 30, 2025
Prevents device type from being overwritten during SMART info collection. This preserves user-configured device types for drives that require specific type settings (e.g., USB bridges, RAID controllers). Origin: AnalogJ#803 Original author: @thomashilzendegen
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #608 as it was overriding a configured device type from the
collector.yamlwith the (in my case wrong) results from thesmartctl --infocommand (device.typeJSON element).