Improve test coverage and config validation for launch readiness#16
Merged
AngeloGiacco merged 1 commit intomainfrom Feb 16, 2026
Merged
Improve test coverage and config validation for launch readiness#16AngeloGiacco merged 1 commit intomainfrom
AngeloGiacco merged 1 commit intomainfrom
Conversation
- Add strict config validation: checks referenced in human/agent mode must be defined in [checks], parallel group checks must be in agent.checks, and check commands cannot be empty - Add default test-unit check definition so default config validates - Add 14 Detector tests exercising actual detection logic with controlled env vars (priority ordering, all detection strategies) - Add 47 Error type tests covering all variants, constructors, Display impls, exit codes, is_user_error, and source chains - Add 17 Runner execution tests with real command execution (passing/failing/mixed checks, env vars, fail-fast, conditional skipping, mode selection, duration recording) - Add 15 config deserialization edge case tests (partial configs, multiline commands, parallel groups, load from file, invalid TOML) - Add 41 CLI parsing tests for all subcommands, aliases, flags, mode/preset validation, and color choices - Test count: 166 -> 357 (115% increase) https://claude.ai/code/session_016PE7AHMMQj4m7iLKKppWst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
must be defined in [checks], parallel group checks must be in
agent.checks, and check commands cannot be empty
controlled env vars (priority ordering, all detection strategies)
Display impls, exit codes, is_user_error, and source chains
(passing/failing/mixed checks, env vars, fail-fast, conditional
skipping, mode selection, duration recording)
multiline commands, parallel groups, load from file, invalid TOML)
mode/preset validation, and color choices
https://claude.ai/code/session_016PE7AHMMQj4m7iLKKppWst