[1.2.2] explictly initialize the atomic timer_state_t to fix compile error in some configurations#1742
Draft
spoonincode wants to merge 1 commit intorelease/1.2from
Draft
[1.2.2] explictly initialize the atomic timer_state_t to fix compile error in some configurations#1742spoonincode wants to merge 1 commit intorelease/1.2from
timer_state_t to fix compile error in some configurations#1742spoonincode wants to merge 1 commit intorelease/1.2from
Conversation
heifner
approved these changes
Jul 22, 2025
Contributor
heifner
left a comment
heifner
left a comment
There was a problem hiding this comment.
Looks harmless enough to me.
greg7mdp
approved these changes
Jul 22, 2025
Contributor
|
Yes, it seems that the change should not be needed. Related discussion which was adopted in Belfast https://wg21.link/P0883. I wonder why clang-20 is not happy. |
Contributor
Author
|
i've still been snooping around what the upstream problem may be as I'd rather not commit this (easy to become cruft which is never removed). I did find gcc-mirror/gcc@613f8dd which for a moment I thought was the fix, but that is actually in gcc15... so maybe that's what broke things 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With clang 20 + libstdc++15 this code is erroring out with
afaict the code is correct for c++20, but this combination of compiler + stdlib seems to be unable to determine that
timer_state_tis default constructable (well I think that's the problem). The annoying thing is I wasn't able to reproduce this in a smaller test case, so I wonder if something else is goofy. I don't really want to make this change so sending up as draft to see if anyone else has thoughts.