fix: Leg folder rename jnt -> Joints and Mus -> Muscles#173
Conversation
|
I currently can't make the default The intention: We can then escalate from warning to error in a later 4.x version |
bkje14
changed the title
jnt -> Jointsjnt -> Joints and Mus -> Muscles
mdabt
left a comment
mdabt
left a comment
There was a problem hiding this comment.
Looks good.
A few small comments, some are actually unrelated to the topic of this PR
| // The model will need the following quantities | ||
| // AnyVec3 Nodes | ||
| // AnyVec3 Segments | ||
| // AnyVec3 Segments |
There was a problem hiding this comment.
Look odd, AnyVec3.
Are these colors? The we have AnyRGB (and AnyRGBs for an array)
There was a problem hiding this comment.
I think it is a old comment that has been copied around a lot. It is the same kind of comment that you marked here: #173 (comment)
| // ********************************************************** | ||
| // This is a reference to where the colors for the model are located | ||
| // The model will need the following quantities | ||
| // AnyVec3 Nodes |
There was a problem hiding this comment.
it is outdated - I think it tries to refer to what is expected inside the drawsettings.
2 participants
This PR is the next step in unifying the bodymodel structure.
.Leg.Jntfolder intoLeg.JointsLeg.MusintoLeg.MusclesLeg.ModelParameterstoLeg.Data.unscaled.ModelParametersLeg.DocLinktoLeg.DocumentationLeg.MusDrawRefas it was unusedIt also re-arranges the folders in
Legto put the most relevant folders first.There is a associated PR to the data repo for the auto generated files affected:
https://github.com/AnyBody/ammr-data/pull/16