Skip to content

Conversation

@al-af
Copy link
Contributor

@al-af al-af commented Dec 7, 2025

Core Fixes

Android: CallbackGuard

  • Added CallbackGuard class to prevent double callback invocation (thread-safe, leak-safe)
  • Applied to all 20+ @ReactMethod callbacks in RNAppsFlyerModule.java
  • Impact: Fixes crashes in React Native New Architecture

Expo Android: Backup Rules (Issue #631)

  • Removed hardcoded expo-secure-store XML references
  • Added preferAppsFlyerBackupRules opt-in flag
  • Default: no longer modifies app's backup rules
  • Impact: Fixes Expo Android build failures when expo-secure-store is absent

iOS: Swift Header Import (PR #653)

  • Added fallback import mechanism in PCAppsFlyer.m for different CocoaPods configurations
  • Impact: Fixes build issues across CocoaPods setups

Version Updates

  • Android SDK: 6.17.3 → 6.17.5
  • iOS SDK: 6.17.7 → 6.17.8 (Framework, Strict, PurchaseConnector)
  • Plugin: 6.17.7 → 6.17.8

API Changes

validateAndLogInAppPurchase

  • v1: Marked @deprecated
  • v2: Promoted to stable (removed "Beta"), docs updated with iOS error handling examples

TypeScript (index.d.ts)

  • Fixed import paths for Purchase Connector models
  • Fixed type names: onFailureOnFailure
  • Updated additionalParameters type, StoreKitVersion readonly, AppsFlyerConsent types

Testing & Tooling

  • New: compatibility.test.js - backward compatibility tests
  • New: linting.test.js - ESLint validation tests
  • Updated: index.test.js - uncommented validateAndLogInAppPurchaseV2 tests
  • Updated: jest.config.js - includes all .test.js files
  • New: .eslintrc.js + lint scripts in package.json

Documentation

  • RN_API.md: Updated consent flow, v2 purchase API, deprecation notices
  • RN_ExpoInstallation.md: Added preferAppsFlyerBackupRules documentation
  • RN_InAppEvents.md: Added v1 API deprecation notice
  • RN_EspIntegration.md: Updated backup rules references

Cleanup

  • Removed ios/AppsFlyerLib-Swift.h (its auto-generated)

@al-af al-af requested a review from amit-kremer93 December 7, 2025 12:12
Copy link
Contributor

@amit-kremer93 amit-kremer93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 2 general notes but in general looks good

@al-af al-af merged commit e0607e1 into development Dec 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants