Skip to content

⚡ Bolt: Fix O(N) memory leak in NZB parsing #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xbmc4lyfe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Fix O(N) memory leak in NZB parsing #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions verify_nzb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,11 @@ def parse_nzb_message_ids(path: str | Path) -> Iterator[str]:

with open(path, "rb") as handle:
for event, elem in ET.iterparse(handle, events=("end",)):
if _local_name(elem.tag) != "segment":
continue
text = (elem.text or "").strip()
if text:
yield text
if _local_name(elem.tag) == "segment":
text = (elem.text or "").strip()
if text:
yield text
# Always clear the element to prevent memory leaks from building the entire DOM tree
elem.clear()


Expand Down