fix(ipc): encode StandaloneDevice::registry_model_id as Option for bincode

[rekcilyssup]

Summary

Fixes #571 — StandaloneDevice::registry_model_id used skip_serializing_if = "Option::is_none" which is safe for JSON but not for bincode (non-self-describing). When the field is None, the encoded AgentSnapshot is truncated and the GUI fails to decode every poll, losing the entire inventory while such a device is present.

Changes

• crates/openlogi-core/src/device.rs:410: drop skip_serializing_if, keep #[serde(default)]
• crates/openlogi-ipc/src/ipc.rs:55: bump PROTOCOL_VERSION 23 → 24 (append-only wire format rule)
• crates/openlogi-ipc/tests/wire_format.rs:66: make assert_wire round-trip (deserialize + re-encode check) without requiring PartialEq on tarpc-generated types; pin version to 24 and regenerate registry_model_id = None golden (…6100 instead of …61)
• crates/openlogi-agent/src/bin/mock_agent.rs:432: remove obsolete workaround comment (keeps Some("8c900") for asset lookup)

Testing

• DEVELOPER_DIR=/Library/Developer/CommandLineTools cargo test -p openlogi-ipc --test wire_format — 13 passed (including round-trip)
• cargo test -p openlogi-core -p openlogi-ipc -p openlogi-hid -p openlogi-agent-core — passed
• cargo clippy -p openlogi-core -p openlogi-ipc -p openlogi-agent --all-targets -- -D warnings — clean
• RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --exclude openlogi-ui --exclude openlogi-desktop --exclude openlogi-overlay — clean
• Manual verification: StandaloneDevice { registry_model_id: None } round-trips via bincode::DefaultOptions before/after; Some("8c900") golden unchanged

Fixes #571

[greptile-apps]

Greptile Summary

This PR fixes bincode serialization of an absent StandaloneDevice::registry_model_id and versions the resulting IPC wire-format change.

• Always encodes the trailing optional registry model ID.
• Bumps the IPC protocol version from 23 to 24.
• Strengthens golden-wire tests with decode/re-encode validation.
• Removes the obsolete mock-agent workaround explanation.

Confidence Score: 5/5

The PR appears safe to merge, with the serialization fix, protocol-version guard, and updated wire tests aligned.

The changed optional field remains appended, is now encoded consistently for bincode, and incompatible GUI and agent versions are rejected before snapshot decoding.

Important Files Changed

Filename	Overview
crates/openlogi-core/src/device.rs	Removes conditional omission of the trailing optional field so bincode emits an explicit None tag.
crates/openlogi-ipc/src/ipc.rs	Correctly bumps and documents the protocol version for the changed positional wire encoding.
crates/openlogi-ipc/tests/wire_format.rs	Updates the None golden bytes and adds deserialization plus canonical re-encoding checks to all pinned wire values.
crates/openlogi-agent/src/bin/mock_agent.rs	Removes an obsolete workaround comment while retaining the real registry ID used for asset lookup.

_{Reviews (1): Last reviewed commit: "fix(ipc): encode StandaloneDevice::regis..." | Re-trigger Greptile}