fix(linux): run an "Open application" target instead of xdg-opening it

[4ni1ak]

Summary

An Actions Ring slot configured with an application did nothing on Linux.

Split out of #802 at your request.

Fixes #775

Changes

Action::OpenApplication handed its target straight to opener::open, which on
Linux is xdg-open — and xdg-open opens a file. Given /usr/bin/nautilus it
looks for a handler claiming application/x-executable, finds none, and does
nothing, so the slot looked dead.

On Linux the target is now classified first:

• an executable file path, or a bare command name resolved on PATH, is spawned
  as a program;
• URLs, folders, documents and .desktop entries stay with the opener — a
  desktop entry especially, since xdg-open reads its Exec= and honours
  Terminal= and StartupNotify=, none of which spawning the file would.

macOS and Windows keep going through the opener, where open and
ShellExecute already run .app bundles and .exes.

The child is waited on from a detached thread, so a long-lived GUI app is not
left as a zombie for the agent's lifetime. The decision table takes its two
filesystem probes as parameters, so it is unit-tested with fakes rather than
against the host.

Testing

Linux, x86_64, Rust 1.98.0:

cargo test -p openlogi-inject
cargo fmt --all -- --check
cargo clippy --workspace --all-targets -- -D warnings           # RUSTFLAGS=-D warnings
cargo clippy --target x86_64-pc-windows-gnu -p openlogi-inject \
  --all-targets -- -D warnings                                  # cfg cross-check
cargo test --workspace

All green. New tests:
executables_are_run_and_everything_else_goes_to_the_opener,
an_executable_desktop_entry_still_goes_to_the_opener, and
the_real_probes_resolve_a_shell_on_path, which pins the two real filesystem
probes against sh on PATH rather than only the fakes.

Not run on this host: tests (macos), cargo-deny, macOS clippy — no macOS
SDK here. The Windows cross-lint covers the non-Linux side of the one
#[cfg(target_os = "linux")] statement added to inject.rs.

Not runtime-tested. To verify: configure /usr/bin/nautilus and bare
nautilus in an Actions Ring slot — both should launch the file manager — and
confirm a folder path and an https:// URL still open as before.

[greptile-apps]

Greptile Summary

The PR changes Linux application-target handling so executable paths and commands found on PATH are spawned directly, while URLs, documents, directories, and desktop entries continue through the desktop opener.

• Adds Linux-specific target classification and PATH resolution.
• Spawns programs synchronously, then waits for successful children on a detached thread.
• Adds tests for executable classification, desktop entries, PATH lookup, and spawn failures.

Confidence Score: 4/5

The PR is not yet safe to merge because non-permission spawn failures still repeat the failed executable launch through the desktop opener.

A target that passes the execute-bit check but fails to spawn for reasons other than permission denial is still passed unchanged to the opener, which does not run executable files and therefore leaves the Actions Ring slot inert.

Files Needing Attention: crates/openlogi-inject/src/inject/linux.rs, crates/openlogi-inject/src/inject.rs

Important Files Changed

Filename	Overview
crates/openlogi-inject/src/inject.rs	Routes Linux OpenApplication targets through launch_program before retaining the existing desktop-opener fallback.
crates/openlogi-inject/src/inject/linux.rs	Adds executable classification and direct spawning, but non-permission spawn failures still send the unchanged executable to the opener, leaving the previously reported fallback defect outstanding.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[OpenApplication target] --> B{Linux target classification}
    B -->|URL, document, directory, desktop entry| C[Desktop opener]
    B -->|Executable path or PATH command| D[Command spawn]
    D -->|Success| E[Detached child wait]
    D -->|Permission denied| F[Log and report handled]
    D -->|Other spawn error| C

Loading

_{Reviews (5): Last reviewed commit: "fix(linux): don't hand an unexecutable p..." | Re-trigger Greptile}