Add explicit conversions from bytes32 to uint256 to allow binary operations#31
Open
ekpyron wants to merge 1 commit intoArachnid:masterfrom
ekpyron:literalBytesConversions
Open
Add explicit conversions from bytes32 to uint256 to allow binary operations#31ekpyron wants to merge 1 commit intoArachnid:masterfrom ekpyron:literalBytesConversions
ekpyron wants to merge 1 commit intoArachnid:masterfrom
ekpyron:literalBytesConversions
Conversation
rezaeghbal01
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In solidity 0.5.0 (see argotorg/solidity#4696) we will restrict implicit (and explicit) conversions between number literals and bytesXX types. Among others this will prevent binary operations between bytesXX and hex literals that have a different size (i.e. number of digits) - explicit casts become necessary. This PR adds the necessary explicit conversions to
strings.sol.