Skip to content

refactor(p2p): pack protobuf validator bitmaps - #1447

Draft
oXtxNt9U wants to merge 3 commits into
feat/p2p/get-proposal-roundfrom
refactor/p2p/packed-header-bitmaps
Draft

refactor(p2p): pack protobuf validator bitmaps#1447
oXtxNt9U wants to merge 3 commits into
feat/p2p/get-proposal-roundfrom
refactor/p2p/packed-header-bitmaps

Conversation

@oXtxNt9U

@oXtxNt9U oXtxNt9U commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • the header bitmaps (every request and response) and the getMessages bitmaps are now one count byte plus the validatorSetPack bigint instead of one byte per validator
  • packing and unpacking happens transparently at the codec level, everything else is untouched

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.16129% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.32%. Comparing base (8e735c3) to head (809bcb2).

Files with missing lines Patch % Lines
...es/p2p/source/socket-server/codecs/proto/protos.js 39.13% 56 Missing ⚠️
...s/p2p/source/socket-server/codecs/get-api-nodes.ts 0.00% 2 Missing ⚠️
...ages/p2p/source/socket-server/codecs/get-blocks.ts 0.00% 2 Missing ⚠️
...kages/p2p/source/socket-server/codecs/get-peers.ts 0.00% 2 Missing ⚠️
...es/p2p/source/socket-server/codecs/get-proposal.ts 0.00% 2 Missing ⚠️
...es/p2p/source/socket-server/codecs/get-messages.ts 66.66% 1 Missing ⚠️
...ackages/p2p/source/socket-server/codecs/headers.ts 94.11% 1 Missing ⚠️
...es/p2p/source/socket-server/codecs/post-message.ts 0.00% 1 Missing ⚠️
...s/p2p/source/socket-server/codecs/post-proposal.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feat/p2p/get-proposal-round    #1447      +/-   ##
===============================================================
+ Coverage                        77.18%   80.32%   +3.13%     
===============================================================
  Files                              963      964       +1     
  Lines                            17141    17110      -31     
  Branches                          2462     2475      +13     
===============================================================
+ Hits                             13231    13744     +513     
+ Misses                            3903     3359     -544     
  Partials                             7        7              
Flag Coverage Δ
contracts 91.76% <ø> (ø)
packages 80.02% <45.16%> (+3.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oXtxNt9U
oXtxNt9U marked this pull request as ready for review August 10, 2026 04:33
@oXtxNt9U
oXtxNt9U force-pushed the refactor/p2p/packed-header-bitmaps branch from 71628dc to e5abb75 Compare August 20, 2026 01:42
@oXtxNt9U
oXtxNt9U force-pushed the refactor/p2p/packed-header-bitmaps branch from 76d017c to bac397b Compare August 25, 2026 05:51
@oXtxNt9U
oXtxNt9U marked this pull request as draft August 26, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant