Skip to content

test(functional): fix more flaky consensus tests - #1474

Merged
oXtxNt9U merged 4 commits into
developfrom
fix/test/functional-consensus
Sep 2, 2026
Merged

test(functional): fix more flaky consensus tests#1474
oXtxNt9U merged 4 commits into
developfrom
fix/test/functional-consensus

Conversation

@oXtxNt9U

@oXtxNt9U oXtxNt9U commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Ensure all message count asserts that include nil votes produced by timeouts are awaited first.

This should hopefully fix all remaining tests together with #1471

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.41%. Comparing base (48a0795) to head (53366eb).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1474      +/-   ##
===========================================
+ Coverage    78.05%   78.41%   +0.35%     
===========================================
  Files          953      964      +11     
  Lines        16312    16749     +437     
  Branches      2350     2425      +75     
===========================================
+ Hits         12733    13134     +401     
- Misses        3574     3608      +34     
- Partials         5        7       +2     
Flag Coverage Δ
contracts 91.76% <ø> (?)
packages 78.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oXtxNt9U
oXtxNt9U merged commit d2844bb into develop Sep 2, 2026
24 checks passed
@oXtxNt9U
oXtxNt9U deleted the fix/test/functional-consensus branch September 2, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants