-
Notifications
You must be signed in to change notification settings - Fork 249
GNG L1 update #2558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
GNG L1 update #2558
Conversation
added photos for 6.2
Added a note to include a photo when selecting the 3D (URP) Core template.
Updated instructions for preparing a Unity project for Android, including changes to menu options and added clarifications.
Updated images in the setup guide for Unity on Android to reflect the latest version.
| 1. Once recognized, your device will be listed in the drop-down menu next to _Run Device_ | ||
|
|
||
| 1. The screenshot below shows the settings with a _Samsung S8_ selected as the _Run Device_ | ||
| 1. The screenshot above shows the settings with a our demo device selected as the _Run Device_ you will see you own device in this box |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo: "you" should be "your" here.
| 1. Build and deploy to your Android device: | ||
| - Open _File/Build Settings_ | ||
| - Open _File/Build profiles_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a capital "P" here.
| Before you can use the Analyzer tool, you need to install the related package it comes in. Follow these steps with the Package Manager: | ||
|
|
||
| 1. Select menu option _Window/Package Manager_ | ||
| 1. Select menu option _Window/Package Management/PacketManager_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "Package Manager" instead of "PacketManager".
updated in accordance to edits
updated in accordance with comments
|
commit f061f7d needs to be reverted. accidentally put the png into the wrong folder. how do I delete this? |
updated within lines of comments made
|
all updates have been made with accordance to comments by Ed |
BmanClark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things before can merge.
| 1. Select _File->Build Profile_ to show the Build Profile window: | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the images aren't showing on this page for me. Code looks correct, but can you please check? Probably need to clean up the 2/3 versions of each image that you're not using anyway (with underscores and spaces)
| 1. To activate profiling, we will enable the _Development Build_ and _Autoconnect Profiler_ options. | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same image not showing here for me either. Wonder if the multiple versions are confusing it?
|
|
||
|  | ||
|
|
||
| 1. Enter project name (this will be used as the name of the project folder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new images are good, but they're causing numbered lists to start from 1 again - will need to get adjust markdown to cope. (is it more spaces before image line? eg line 75 works without interrupting number sequencing)
| 1. Select _Android_ from the Platform list | ||
|
|
||
| 1. Select _Switch Platform_ | ||
| 1. Select _Switch Platform_as you have done in the [previous learning path](https://learn.arm.com/learning-paths/mobile-graphics-and-gaming/get-started-with-unity-on-android/3-test-on-android/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space after "Platform_" means it isn't in italics.
|  | ||
|  | ||
|
|
||
| if it doesn't then follow the steps below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to run the steps below regardless. And if should be capital "If".
Suggest just removing this line. If you want to keep it then:
"If it doesn't then our next steps should hopefully reveal the issue."
| It is worth checking that everything has imported and been built correctly. | ||
|
|
||
| 1. Close the _Build Settings_ window | ||
| 1. Close the _Build profiles_ window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Build Profiles"
| 1. Select _Switch Platform_ | ||
| 1. Select _Switch Platform_as you have done in the [previous learning path](https://learn.arm.com/learning-paths/mobile-graphics-and-gaming/get-started-with-unity-on-android/3-test-on-android/) | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Build Profiles"
| 1. Once recognized, your device will be listed in the drop-down menu next to _Run Device_ | ||
|
|
||
| 1. The screenshot below shows the settings with a _Samsung S8_ selected as the _Run Device_ | ||
| 1. The screenshot above shows the settings with a our demo device selected as the _Run Device_ you will see your own device in this box |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"with a our demo device" - a or our.
Also would be better with full stop after "Run Device" and Capital "You will ..."
I've also just noticed that LP has inconsistent full-stops at end of numbered bullets. Most important is to be consistent, but as many are >1 sentence, probably add full-stops to end of each of them?
| In our sample, the performance issues will be apparent soon after launch. To profile directly on an Android device: | ||
|
|
||
| 1. Open the _Build Settings_ | ||
| 1. Open the _Build Profile_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build Profiles
|
|
||
| If you forget to tick the auto-connect option or you want to wait before you connect the Profiler, you can connect the Profiler while the app is running: | ||
|
|
||
| Whilst inside the unity editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many folk just use "While" now, so whilst I'm a fan, we should probably go with that (at least that's what content services/techdocs do to my "whilsts").
But more importantly Unity should be capital, I think Editor should be too (check other usages), and the sentence should have a colon at the end.
…with-unity-on-android/images/build profiles android.png
…with-unity-on-android/images/build_profiles_android.png
…with-unity-on-android/images/scene list.png
…with-unity-on-android/images/scene_list.png
|
Hi Ben, When I view the markdowns I can see the images clearly on my end. The rest of the changes have been made as per comments |
Screenshots on page "Set up" will be updated again when version 6.3 becomes the LTS
I couldn't seem to get the first 2 screen shots replicated.