Skip to content

Conversation

@KATO-Hiro
Copy link
Collaborator

@KATO-Hiro KATO-Hiro commented Dec 30, 2025

close #3007

Summary by CodeRabbit

Release Notes

  • New Features

    • Added numerous new contest tasks spanning multiple JOI series, JOIHO, Typical90, and other contest collections to the platform.
  • Style

    • Improved table layout rendering on large screen viewports for contest displays, providing better use of available space.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

Walkthrough

This pull request expands the task database with numerous new JOI series entries to support local development and updates styling for the JOI Second Qualifying Round provider to accommodate increased problem counts, including adding a large-screen breakpoint for improved table layout.

Changes

Cohort / File(s) Summary
Task Database Expansion
prisma/tasks.ts
Added bulk task entries across multiple JOI series (joi2026yo, joi2025ho, joi2007yo, joi2006yo, and others), maintaining existing structure with id, contest_id, problem_index, name, title, and optional grade fields.
Contest Table Display Configuration
src/lib/utils/contest_table_provider.ts
Added large-screen breakpoint (lg:w-1/6) to JOI Second Qualifying Round table body cell width configuration, expanding from md-based sizing.
Test Expectations Update
src/test/lib/utils/contest_table_provider.test.ts
Updated test assertion for JOI Second Qual Round 2020 Onwards display config to include new lg:w-1/6 breakpoint in tableBodyCellsWidth.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hop, hop, hooray! — the tasks now grow,
New JOI contests in a row,
Tables stretch at larger screens,
Wider cells for problems keen,
Six problems now, the future's here! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title mentions fixing style and adding seed data for JOI 2nd, which directly aligns with the main changes: adding task seed data and fixing display styles for JOI second round.
Linked Issues check ✅ Passed The PR fulfills both objectives from #3007: it adds seed data for JOI tasks across multiple years and series to prisma/tasks.ts, and it fixes the display style for JOI second qualifying round by updating the table cell width configuration.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objectives: task seed data additions, style configuration updates for JOI second round display, and corresponding test updates. No extraneous changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e851d50 and a92f566.

📒 Files selected for processing (3)
  • prisma/tasks.ts
  • src/lib/utils/contest_table_provider.ts
  • src/test/lib/utils/contest_table_provider.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: preview
🔇 Additional comments (3)
src/lib/utils/contest_table_provider.ts (1)

868-868: LGTM! Display configuration updated appropriately.

The addition of the lg:w-1/6 breakpoint correctly accommodates the expanded problem count for JOI Second Qualifying Round contests, allowing for better table layout on large screens when displaying 6 problems instead of 5. This change aligns with the PR's objective of supporting the format transition starting in 2026.

src/test/lib/utils/contest_table_provider.test.ts (1)

2270-2272: LGTM! Test expectation correctly updated.

The test assertion now properly validates the updated display configuration including the lg:w-1/6 breakpoint, ensuring alignment with the implementation change.

prisma/tasks.ts (1)

6781-7159: Data additions are well-structured and correctly formatted.

The new JOI contest entries (lines 6781–7159) are properly formatted and maintain consistency with existing entries:

  • All required fields present (id, contest_id, problem_index, name, title)
  • No duplicate IDs detected across the additions
  • Naming conventions consistent: IDs use underscores; contest_id uses concatenation
  • Problem counts align with contest format specifications (joi2026yo2 correctly includes 6 problems; other years include 5)
  • Optional grade field usage is appropriate and matches existing patterns
  • No modifications to existing entries; clean append-only addition

The additions support the PR objectives of adding seed data for JOI 2nd round and semifinal rounds, with the 2026 second round correctly reflecting the new 6-problem format.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator Author

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit 5d461e9 into staging Dec 30, 2025
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #3007 branch December 30, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] JOI 二次予選のスタイル修正 + ローカル環境用のseedデータの追加をしましょう

2 participants