Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2026

Bumps globals from 16.5.0 to 17.0.0.

Release notes

Sourced from globals's releases.

v17.0.0

Breaking

  • Split audioWorklet environment from browser (#320) 7bc293e

Improvements

  • Update globals (#329) ebe1063
  • Get all browser globals from both chrome and firefox (#321) 59ceff8
  • Add bunBuiltin environment (#324) 1bc6e3b
  • Add denoBuiltin environment (#324) 1bc6e3b
  • Add paintWorklet environment (#323) 4b78f56
  • Add sharedWorker environment (#322) 4a02a85

sindresorhus/globals@v16.5.0...v17.0.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [globals](https://github.com/sindresorhus/globals) from 16.5.0 to 17.0.0.
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](sindresorhus/globals@v16.5.0...v17.0.0)

---
updated-dependencies:
- dependency-name: globals
  dependency-version: 17.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 1, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@KATO-Hiro
Copy link
Collaborator

@coderabbitai

Split audioWorklet environment from browser (#320) 7bc293e の影響があるか調べて

@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@KATO-Hiro: このbreaking changeの影響を調査します。


🏁 Script executed:

#!/bin/bash

# Find ESLint configuration files
echo "=== ESLint Configuration Files ==="
fd -e js -e json -e yaml -e yml -e cjs -e mjs . | grep -E "(eslint|\.eslintrc)" | head -20

# Search for audioWorklet references in the codebase
echo -e "\n=== AudioWorklet References ==="
rg -i "audioworklet" -C 2

# Check package.json for globals usage and eslint configuration
echo -e "\n=== package.json contents ==="
cat package.json

# Check if there's an eslint config file
echo -e "\n=== ESLint Config (.eslintrc.json) ==="
if [ -f .eslintrc.json ]; then
  cat .eslintrc.json
fi

echo -e "\n=== ESLint Config (eslint.config.js) ==="
if [ -f eslint.config.js ]; then
  cat eslint.config.js
fi

echo -e "\n=== ESLint Config (eslint.config.mjs) ==="
if [ -f eslint.config.mjs ]; then
  cat eslint.config.mjs
fi

Length of output: 6004


@KATO-Hiro: 調査結果をお伝えします。

調査内容

  1. ESLint設定の確認

    • eslint.config.mjsglobalsパッケージを使用しています
    • 現在の設定: ...globals.browser...globals.nodeを使用
  2. audioWorklet参照の検索

    • コードベース全体を検索しましたが、audioWorkletへの参照は見つかりませんでした

結論

このbreaking changeによる影響はありません 🎉

理由

  • globals 17.0.0ではaudioWorklet環境がbrowser環境から分離されましたが、このリポジトリではAudioWorkletProcessoraudioWorklet関連のAPIを使用していません
  • globals.browserを使用しているだけで、実際に音声処理関連のWeb Audio APIのワークレット機能を利用していない場合、この変更の影響はありません

参考情報

もし将来的にaudioWorklet関連のAPIを使用する場合は、eslint.config.mjslanguageOptions.globalsに以下を追加する必要があります:

languageOptions: {
  globals: {
    ...globals.browser,
    ...globals.audioWorklet,  // 追加
    ...globals.node,
    // ...
  },
}

@KATO-Hiro KATO-Hiro merged commit 1761c55 into staging Jan 1, 2026
4 checks passed
@KATO-Hiro KATO-Hiro deleted the dependabot/npm_and_yarn/globals-17.0.0 branch January 1, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants