-
-
Notifications
You must be signed in to change notification settings - Fork 10
fix: Revert pnpm from 10.27.0 to 10.26.2 (#3022) #3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR resolves a memory leak in pnpm v10.27.0 that caused the development server to crash with out-of-memory errors. The fix downgrades pnpm to v10.26.2 and includes comprehensive documentation of the investigation and remediation process. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/dev-notes/2026-01-02/pnpm-10.27-regression/report.md (1)
44-44: Consider using proper heading syntax.Lines 44 and 58 use bold emphasis for what appear to be section headings. Consider converting them to proper Markdown headings for better document structure and to resolve the markdownlint warnings.
🔎 Suggested changes
For line 44:
-**pnpm v10.27.0 の semi-breaking change** +### pnpm v10.27.0 の semi-breaking changeFor line 58:
-**pnpm をダウングレード:v10.27.0 → v10.26.2** +### pnpm をダウングレード:v10.27.0 → v10.26.2Also applies to: 58-58
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
docs/dev-notes/2026-01-02/pnpm-10.27-regression/report.mdpackage.json
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/dev-notes/2026-01-02/pnpm-10.27-regression/report.md
44-44: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
58-58: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: preview
🔇 Additional comments (3)
package.json (2)
91-91: Consistent version across package.json.The
packageManagerfield correctly matches the pnpm devDependency version (10.26.2), ensuring consistency throughout the package configuration.
48-48: Downgrade to pnpm 10.26.2 is justified and secure.This change correctly addresses the heap out-of-memory issue by avoiding the semi-breaking changes introduced in pnpm 10.27.0. The 10.27.0 release modified the global virtual store structure (moving unscoped packages to an "@" directory and registering projects under {storeDir}/v10/projects/), which requires store migration. Version 10.26.2 is stable with no known security advisories and includes the latest security defaults. The change is approved.
docs/dev-notes/2026-01-02/pnpm-10.27-regression/report.md (1)
1-132: Excellent documentation of the investigation and resolution.This document provides comprehensive documentation of the memory issue investigation, including:
- Clear problem symptoms and error messages
- Systematic hypothesis testing with results
- Root cause analysis with external references
- Step-by-step resolution instructions
- Acknowledgment of environment-specific factors and uncertainty
The thorough documentation will be valuable for future maintenance and similar issues.
KATO-Hiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #3022
Summary by CodeRabbit
Bug Fixes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.