Add search bar and print PDF buttons#867
Open
lbourdois wants to merge 35 commits intoAtcold:masterfrom
Open
Conversation
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Advance the jekyllbook submodule to include the print cover link labeling fix for the French and English course website links. Made-with: Cursor
Advance the jekyllbook submodule to include the print cover fix that restores clickable course links on the cover page. Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Atcold What I mentioned to you in my message
Some details about the implementation:
docsfolder, where need to specify to use my modified version of jekyllbook (https://github.com/lbourdois/jekyllbook). In particular, https://github.com/lbourdois/jekyllbook/blob/master/_layouts/default.html, which contains the main additions (the search bar and the PDF print function, where we had to address quite a few issues such as themes, equation rendering, etc.)_config.ymlcontains lines to configure the PDF cover page that I add before printing the site as-is as a PDFprint.mdfile to generate the PDF in English; for all other languages, you must add aprint.mdfile to each language folder (e.g.: https://github.com/lbourdois/NYU-DLSP20/blob/master/docs/fr/print.md)Loïck