Skip to content

fix(handler): bind this into uncaught handler #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlenon7 merged 1 commit into from
Mar 29, 2026
+7 −5
Merged

fix(handler): bind this into uncaught handler #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@athenna/core",
"version": "5.39.0",
"version": "5.40.0",
"description": "One foundation for multiple applications.",
"license": "MIT",
"author": "João Lenon <lenon@athenna.io>",
Expand Down
6 changes: 4 additions & 2 deletions src/ignite/Ignite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export class Ignite extends Macroable {
exitOnUncaughtError: false,
loadConfigSafe: true,
athennaRcPath: './.athennarc.json',
uncaughtExceptionHandler: this.handleUncaughtError
uncaughtExceptionHandler: this.handleUncaughtError.bind(this)
})

this.setUncaughtExceptionHandler()
Expand Down Expand Up @@ -218,6 +218,8 @@ export class Ignite extends Macroable {
* providers and preload files.
*/
public async fire(forceIgniteFire?: boolean) {
Config.set('rc.environments', this.options.environments)

if (this.hasFired && !forceIgniteFire) {
debug(
'application already fired. if you need to refire use forceIgniteFire option in your application bootstrap.'
Expand All @@ -232,7 +234,7 @@ export class Ignite extends Macroable {
this.setEnvVariablesFile()
await this.setConfigurationFiles()

Config.push('rc.environments', this.options.environments)
Config.set('rc.environments', this.options.environments)

await LoadHelper.regootProviders()
await LoadHelper.preloadFiles()
Expand Down
Loading