Repository navigation
Conversation
Implement the velocity and odometry motion models of Thrun, Burgard and Fox, Probabilistic Robotics, chapter 5. - velocity model: closed form of Table 5.1 and sampler of Table 5.3, with the signed radius of equation 5.17 and wrapped heading differences - odometry model: closed form of Table 5.5 and sampler of Table 5.6, with frame-invariant handling of a zero translation - tests for straight and backward motion, angle wrapping, the forward right turn, frame invariance, the pure-rotation and large-turn limits, sampler/density agreement, and the missing Jacobian - documentation page with the equations, the two book findings, and the identifiability limits Refs: AtsushiSakai#1516 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Hi @AtsushiSakai, the GitHub Actions checks on this PR (Linux_CI, MacOS_CI, Windows_CI, Code scanning) are all showing The change has been verified locally with the same environment as CI (Python 3.14 + pinned
Could you approve the workflow runs when you have a moment? Thanks! |
Tables 5.1 and 5.3 of Probabilistic Robotics specify the velocity noise variances as alpha1 v^2 + alpha2 omega^2, and Tables 5.5 and 5.6 specify the odometry variances as alpha1 d_rot1^2 + alpha2 d_trans^2, and so on. The implementation used absolute values instead, and the odometry translation variance grouped the rotations as alpha4 |d_rot1 + d_rot2| instead of alpha4 d_rot1^2 + alpha4 d_rot2^2. Update the module, its tests and the documentation to match the book, and refresh the numbers quoted in the docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the velocity and odometry motion models of Thrun, Burgard and Fox, Probabilistic Robotics, chapter 5.
Refs: #1516
Reference issue
What does this implement/fix?
Additional information
CheckList