Fix errors highlighted by akismet-react app#31
Closed
eoigal wants to merge 4 commits into
Closed
Conversation
@extend cannot be used within a media breakpoint without causing errors.
Contributor
|
Good catches. |
|
Can this get fixed and merged? akismet-react is unusable by anyone who doesn't already have a custom development workflow set up until these conflicts are resolved. |
Contributor
|
Most of these issues have been merged in other PRs, the only remaining issues preventing Akismet from building are now addressed in #71 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dops-components repo is being used by the akismet-react repo but due to recent changes this repo is no longer compatible.
This PR will fix bugs found while trying to make the 2 repos compatible. The PR on akismet-react can be found here.