Migrate the build to webpack 2.#6385
Closed
zinigor wants to merge 2 commits into
Closed
Conversation
Contributor
|
What's the reasoning behind this? |
Contributor
Author
|
The main reasoning is to make the client-side code of Jetpack smaller. I don't actually know how smaller we can make it, but if a simple toolchain upgrade can give us that, I'm thinking we should do it. There's a good article about the general benefits here, plus there's a PR we can look at for inspiration: Automattic/wp-calypso#10799 |
Contributor
|
That's all very cool, and is something we should probably dig into when we do our "shrink jetpack" sprint, but right now we have higher priorities (like getting the settings UI finished) and shouldn't be spending precious dev time on this direction. Closing for now, but I'd love to investigate this more in the future (and let's chat before we do) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP. Needs a companion PR to "work": Automattic/dops-components#89
Changes proposed in this Pull Request:
Still to do:
add-module-exportsplugin no longer work as it has before.