fix(env): provision plugin vendor/ on env up to avoid activation fatal#411
Open
jason10lee wants to merge 2 commits into
Open
fix(env): provision plugin vendor/ on env up to avoid activation fatal#411jason10lee wants to merge 2 commits into
jason10lee wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
A fresh isolated environment (
n env up) links the monorepo plugins but never installs their Composervendor/— so activating a plugin that requires its autoloader (e.g.newspack-plugin,newspack-popups) fatals on a missingvendor/autoload.php. This adds abin/ensure-vendor.shstep at env-up that runs a runtime-only (--no-dev) per-plugin Composer install — all plugin activation needs, without dev dependencies or the slow JS build — so a fresh env is never vendorless. (Dev dependencies for running a plugin's tests still come fromn build/n ci-build.)vendor/autoload.phpis already present, so warm starts stay instant.Only monorepo plugins are provisioned; standalone
repos/checkouts manage their own dependencies.How to test the changes in this Pull Request:
n env up <name>on a fresh environment; confirm the[ensure-vendor]step installs Composer deps for the monorepo plugins.newspack-plugin) — it activates without a fatal about a missingvendor/autoload.php.n env up <name>— confirmensure-vendorskips already-provisioned plugins (no redundant installs).Other information:
bin/test harness in this repo.ensure-vendorran at env-up across the monorepo plugins, with error propagation + graceful degradation confirmed. No CI coverage forbin/here, so verification is manual.