Make Studio CLI available in AppX via AppExecutionAlias#2547
Merged
Conversation
gcsecsey
changed the title
Collaborator
📊 Performance Test ResultsComparing e25cbb0 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
1 task
The npx/shell approach failed on Windows CI with swallowed errors. Calling pkg's exec() directly avoids path resolution, shell escaping, and child process buffer issues.
Without --public, --no-bytecode strips bytecode but pkg also doesn't include the raw source, resulting in an empty executable.
…x-cli-installation-appx-2
Contributor
ivan-ottinger
left a comment
ivan-ottinger
left a comment
There was a problem hiding this comment.
Thank you for detailed description and testing instructions, Gergely. That helps!
I can confirm the changes work correctly. I did not observe any regressions.
Installer version:
Store version:
macOS version
I haven't reviewed the code yet though, but will do so tomorrow with fresh brain.
ivan-ottinger
approved these changes
Feb 11, 2026
…x-cli-installation-appx-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
On Windows AppX (Microsoft Store) installations, the
studioCLI command was not available in the terminal because AppX packages require special handling. This PR:@yao-pkg/pkg, which is configured as a Windows AppExecutionAlias in the AppxManifest. When users typestudioin a terminal, Windows activates the package context and runs the CLI.process.windowsStoreflag for detection.The PR uses a new dependency
@yao-pkg/pkg, but node.js also has a single executable applications feature which could be used to compile it. The downsides of using SEA would be:If not adding a new dependency is more important than the binary size, we could also adapt this approach, because our CI builds are run on Windows already.
Testing Instructions
Store version:
where studio, and check that it outputs a path similar toC:\Users\gcsecsey\AppData\Local\Microsoft\WindowsApps\studio.exestudio site list, these should work as expectedInstaller version:
where studio, and check that it outputs a path similar toC:\Users\gcsecsey\AppData\Local\studio\bin\studio.batstudio site list, these should work as expectedAlso check for any regressions on Mac.
Pre-merge Checklist