Fix Performance Metrics broken import#2617
Closed
gcsecsey wants to merge 2 commits into
Closed
Conversation
The monorepo restructure moved metrics/ to tools/metrics/ but did not update the relative import path. Update ../playwright.config to ../../playwright.config to point to the correct location at the repo root.
gcsecsey
changed the title
Contributor
|
@gcsecsey, this is not enough, and there are more fixes needed there. I'm fixing that in #2615 via @fredrikekelund 's commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Related to #2565
Proposed Changes
../playwright.configto../../playwright.configto point to the correct locationTesting Instructions
npm run test:metrics -- --listto verify the config resolves correctly and tests are listedPre-merge Checklist