Exclude unnecessary items from ASAR archive#3551
Merged
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing a8cf869 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude did the implementation based on my spec.
Proposed Changes
While experimenting with #3545, I got curious about what exactly makes the Studio installer so large. I noticed that the
Contents/Resources/app.asararchive contained some directories that aren't needed:__mocks__e2einstallerssrcThis PR removes them from the output by changing the
ignoreconfig inforge.config.ts. Several entries in that array aren't relevant after the monorepo migration, either, so Claude cleaned up a bunch of additional ones.Testing Instructions
CI should pass.
Pre-merge Checklist