Move front-end-only dependencies to devDependencies#3552
Merged
fredrikekelund merged 6 commits intoMay 20, 2026
Conversation
Collaborator
📊 Performance Test ResultsComparing 2832286 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
devDependenciesdevDependencies
nightnei
approved these changes
May 20, 2026
Contributor
nightnei
left a comment
There was a problem hiding this comment.
I have only concern about version updates, e.g. "react 18.2.0 to 18.3.1" etc. Is it expected or did it happen by mistake?
But, we are adding it to the first beta, so we can test everything carefully, catch potential errors caused by version upgrades, and fix them before the actual Studio release. So it LGTM.
Contributor
Author
This was a consequence of how Claude did it. I was able to rerun the installation command in a different way that seems to have mostly preserved the package versions, but just moved them to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude drove the implementation based on my spec.
Proposed Changes
The ASAR archive in the Electron app build contains a
node_modulesdirectory. We need that directory, but it would be ideal to exclude front-end-only dependencies, since they will already have been bundled by Vite. The idea is to save on the installer file size.This PR does just that.
Testing Instructions
CI should pass.
Pre-merge Checklist