Skip to content

Move front-end-only dependencies to devDependencies#3552

Merged
fredrikekelund merged 6 commits into
trunkfrom
f26d/move-frontend-only-deps-to-devdependencies
May 20, 2026
Merged

Move front-end-only dependencies to devDependencies#3552
fredrikekelund merged 6 commits into
trunkfrom
f26d/move-frontend-only-deps-to-devdependencies

Conversation

@fredrikekelund
Copy link
Copy Markdown
Contributor

@fredrikekelund fredrikekelund commented May 20, 2026

Related issues

How AI was used in this PR

Claude drove the implementation based on my spec.

Proposed Changes

The ASAR archive in the Electron app build contains a node_modules directory. We need that directory, but it would be ideal to exclude front-end-only dependencies, since they will already have been bundled by Vite. The idea is to save on the installer file size.

This PR does just that.

Testing Instructions

CI should pass.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@fredrikekelund fredrikekelund self-assigned this May 20, 2026
@wpmobilebot
Copy link
Copy Markdown
Collaborator

wpmobilebot commented May 20, 2026

📊 Performance Test Results

Comparing 2832286 vs trunk

app-size

Metric trunk 2832286 Diff Change
App Size (Mac) 1376.63 MB 1194.62 MB 182.01 MB 🟢 -13.2%

site-editor

Metric trunk 2832286 Diff Change
load 1498 ms 1494 ms 4 ms ⚪ 0.0%

site-startup

Metric trunk 2832286 Diff Change
siteCreation 8584 ms 8589 ms +5 ms ⚪ 0.0%
siteStartup 4926 ms 4939 ms +13 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@fredrikekelund fredrikekelund changed the title [WIP] Move front-end-only dependencies to devDependencies Move front-end-only dependencies to devDependencies May 20, 2026
@fredrikekelund fredrikekelund requested a review from a team May 20, 2026 12:50
Copy link
Copy Markdown
Contributor

@nightnei nightnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only concern about version updates, e.g. "react 18.2.0 to 18.3.1" etc. Is it expected or did it happen by mistake?
But, we are adding it to the first beta, so we can test everything carefully, catch potential errors caused by version upgrades, and fix them before the actual Studio release. So it LGTM.

@fredrikekelund
Copy link
Copy Markdown
Contributor Author

version updates

This was a consequence of how Claude did it. I was able to rerun the installation command in a different way that seems to have mostly preserved the package versions, but just moved them to devDependencies 👍

@fredrikekelund fredrikekelund enabled auto-merge (squash) May 20, 2026 13:38
@fredrikekelund fredrikekelund merged commit 555117a into trunk May 20, 2026
10 checks passed
@fredrikekelund fredrikekelund deleted the f26d/move-frontend-only-deps-to-devdependencies branch May 20, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants