Theme Experience: Update upsell plans

[Copons]

Fixes DOTTHEM-122

Proposed Changes

• Update the theme upload banner to upsell the Personal plan instead of Business.
• Remove a theme upload banner for Premium plans that never showed up because overridden by the JITM feature.
• Remove a theme upload banner for Atomic and Jetpack sites that never showed up because overridden by the JITM feature.

Note: I've left the Woo Trial equivalents because I'm not familiar enough with the program.

Location	Before	After
/themes/upload/SITE
/themes/SITE?flags=-jitms

Why are these changes being made?

• Summer Special gave every paid plan the ability to upload themes. These banners were leftovers from a previous cleanup effort.

Testing Instructions

Case 1: /themes/upload/SITE

• Select a free site.
• Navigate to the Calypso Theme Showcase.
• Click on "Install new theme" in the top-right corner.
• 👀 Ensure that the banner upsells the Personal plan.

Case 2: /themes/SITE?flags=-jitms

Note: turning off the jitms feature (note the plural!) is needed to prevent overriding the Theme Showcase's upsellBanner feature.

• Select a Premium site.
• Navigate to the Calypso Theme Showcase.
• 👀 Ensure the "upload themes" banner doesn't show anymore.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-162530

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-162530&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-162530&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• command-palette-wp-admin
• help-center
• notifications
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug dotthem-122-free-plan-prompts-business-upgrade-when-uploading-theme on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~17 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper                -23 B  (-0.0%)      -17 B  (-0.0%)
entry-reauth-required        -23 B  (-0.0%)      -17 B  (-0.0%)
entry-main                   -23 B  (-0.0%)      -17 B  (-0.0%)
entry-login                  -23 B  (-0.0%)      -17 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~125 bytes removed 📉 [gzipped])

name    parsed_size           gzip_size
themes       -852 B  (-0.1%)     -125 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~14 bytes removed 📉 [gzipped])

name                                parsed_size           gzip_size
async-load-staging-site-sync-modal        -23 B  (-0.0%)      -14 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[xavier-lc]

Case 2: /themes/SITE?flags=-jitms

Note: turning off the jitms feature (note the plural!) is needed to prevent overriding the Theme Showcase's upsellBanner feature.

• Select a Premium site.
• Navigate to the Calypso Theme Showcase.
• 👀 Ensure the "upload themes" banner doesn't show anymore.

Should I be seeing the banner in production if I go to /themes/SITE with a premium one? Asking because I don't see it there with or without the flag.

[Copons]

Case 2: /themes/SITE?flags=-jitms
Note: turning off the jitms feature (note the plural!) is needed to prevent overriding the Theme Showcase's upsellBanner feature.

• Select a Premium site.
• Navigate to the Calypso Theme Showcase.
• 👀 Ensure the "upload themes" banner doesn't show anymore.

Should I be seeing the banner in production if I go to /themes/SITE with a premium one? Asking because I don't see it there with or without the flag.

@xavier-lc You should, but also the conditions are a bit confusing. Basically you have to reach the end of this function:

wp-calypso/client/my-sites/themes/theme-showcase.jsx

Lines 473 to 501 in 3e3048a

	renderBanner = () => {
	const { loggedOutComponent, upsellBanner, isUpsellCardDisplayed, isSiteECommerceFreeTrial } =
	this.props;
	// Don't show the banner if there is already an upsell card displayed
	if ( isUpsellCardDisplayed ) {
	return null;
	}
	// In ecommerce trial sites, we only want to show upsell banner.
	if ( isSiteECommerceFreeTrial ) {
	if ( upsellBanner ) {
	return upsellBanner;
	}
	return null;
	}
	if ( config.isEnabled( 'jitms' ) && ! loggedOutComponent ) {
	return (
	<AsyncLoad
	require="calypso/blocks/jitm"
	placeholder={ null }
	messagePath="calypso:themes:showcase-website-design"
	/>
	);
	}
	return upsellBanner;
	};

On my test site, I simply needed to turn off the jitms flag, and considered it the least confusing test instruction I could ask for. 😅

[xavier-lc]

@Copons I've checked on trunk with a premium site (/themes/xavilc-dpycm.wordpress.com?flags=-jitms) and the banner does not display because shouldNotDisplay is true on

wp-calypso/client/blocks/upsell-nudge/index.tsx

Line 155 in dc0dea3

const shouldNotDisplay =

due to selectedSiteHasFeature being true for "upload-themes"

[xavier-lc]

LGTM

As mentioned on the description, the upselBanner wasn't showing up anyway on premium sites.

[Copons]

@Copons I've checked on trunk with a premium site (/themes/xavilc-dpycm.wordpress.com?flags=-jitms) and the banner does not display because shouldNotDisplay is true on

wp-calypso/client/blocks/upsell-nudge/index.tsx

Line 155 in dc0dea3

const shouldNotDisplay =

due to selectedSiteHasFeature being true for "upload-themes"

Oh, I see, so it was a case of Summer Special pulling the rug! Thanks for checking!