chore: address admin view coding standards#10
Merged
Conversation
Co-Authored-By: Codex <codex@openai.com>
Co-Authored-By: Codex <codex@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on bringing WPVDB admin view templates closer to WordPress coding standards by tightening output escaping/sanitization and improving nonce handling for admin actions, while also cleaning up markup/indentation.
Changes:
- Improved sanitization/unslashing of
$_GETinputs across admin views and tightened escaping for URLs/JS strings in the status UI. - Refined admin status diagnostics UX (nonce-protected “Run Diagnostics” flow; safer rendering of AJAX-derived strings in the test embedding UI).
- Coding-standards cleanups: strict
in_array, use ofselected()/checked(), translator comments, and markup alignment/indentation updates.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| admin/views/status.php | Hardens admin status/tools UI (nonce verification, escaping, stricter comparisons) and aligns markup/JS output handling. |
| admin/views/settings.php | Sanitizes section/settings-updated query params and replaces manual checkbox handling with core helpers. |
| admin/views/incompatible-db-warning.php | Improves i18n/escaping and makes step rendering safer via esc_html / wp_kses_post. |
| admin/views/incompatible-db-notice.php | Switches admin notice strings to escaped i18n helpers and adds translator context. |
| admin/views/header.php | Tightens table existence checks and standardizes pagination variable naming/usage in the header logic. |
| admin/views/embeddings.php | Improves escaping, i18n, PHPCS scoping, and pagination output sanitization. |
| admin/views/automattic-connect.php | Simplifies and hardens handling of settings-updated query param with proper unslashing/sanitization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Codex <codex@openai.com>
Co-Authored-By: Codex <codex@openai.com>
Co-Authored-By: Codex <codex@openai.com>
Co-Authored-By: Codex <codex@openai.com>
Co-Authored-By: Codex <codex@openai.com>
Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing