Skip to content

feat(Notifications): add option to disable popup background fill #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A1ca7raz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(Notifications): add option to disable popup background fill #2708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quickshell/Common/SettingsData.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,7 @@ Singleton {

property bool notificationOverlayEnabled: false
property bool notificationPopupShadowEnabled: true
property bool notificationPopupBgDisabled: false
property bool notificationPopupPrivacyMode: false
property int overviewRows: 2
property int overviewColumns: 5
Expand Down
1 change: 1 addition & 0 deletions quickshell/Common/settings/SettingsSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,7 @@ var SPEC = {

notificationOverlayEnabled: { def: false },
notificationPopupShadowEnabled: { def: true },
notificationPopupBgDisabled: { def: false },
notificationPopupPrivacyMode: { def: false },
overviewRows: { def: 2, persist: false },
overviewColumns: { def: 5, persist: false },
Expand Down
4 changes: 3 additions & 1 deletion quickshell/Modules/Notifications/Popup/NotificationPopup.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,9 @@ PanelWindow {
sourceWidth: Math.max(0, content.width - (content.cardInset * 2))
sourceHeight: Math.max(0, content.height - (content.cardInset * 2))
targetRadius: win.connectedFrameMode ? Theme.connectedSurfaceRadius : Theme.cornerRadius
targetColor: win.connectedFrameMode ? Theme.floatingSurface : Theme.readableSurface
targetColor: (win.connectedFrameMode && SettingsData.notificationPopupBgDisabled)
? "transparent"

@bbedward bbedward Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also use Theme.withAlpha... instead of "transparent"

: (win.connectedFrameMode ? Theme.floatingSurface : Theme.readableSurface)
borderColor: win.notificationData && win.notificationData.urgency === NotificationUrgency.Critical ? Theme.withAlpha(Theme.primary, 0.3) : Theme.withAlpha(Theme.outline, 0.08)
borderWidth: win.notificationData && win.notificationData.urgency === NotificationUrgency.Critical ? 2 : 0
}
Expand Down
10 changes: 10 additions & 0 deletions quickshell/Modules/Settings/NotificationsTab.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,16 @@ Item {
onToggled: checked => SettingsData.set("notificationPopupShadowEnabled", checked)
}

SettingsToggleRow {
settingKey: "notificationPopupBgDisabled"
visible: SettingsData.connectedFrameModeActive
tags: ["notification", "popup", "background", "color", "fill", "transparent", "blur"]
text: I18n.tr("Disable Background Fill")
description: I18n.tr("Render notification popups with no fill color, letting blur and border show through.")

@bbedward bbedward Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to remove the description for less translation burden, maybe instead show a test notification like changing the position does - which makes it clear whats different from the setting

checked: SettingsData.notificationPopupBgDisabled
onToggled: checked => SettingsData.set("notificationPopupBgDisabled", checked)
}

SettingsToggleRow {
settingKey: "notificationPopupPrivacyMode"
tags: ["notification", "popup", "privacy", "body", "content", "hide"]
Expand Down
Loading