Skip to content

feat(DankBar): add configurable middle-click action on empty bar space#2710

Open
A1ca7raz wants to merge 1 commit into
AvengeMedia:masterfrom
A1ca7raz:bar_blank_middle_click
Open

feat(DankBar): add configurable middle-click action on empty bar space#2710
A1ca7raz wants to merge 1 commit into
AvengeMedia:masterfrom
A1ca7raz:bar_blank_middle_click

Conversation

@A1ca7raz

Copy link
Copy Markdown
  • New per-bar "Middle Click" setting in DankBar Settings (SettingsDropdownRow)
  • Options: None / Toggle Control Center / Toggle Launcher / Close Active Window / Toggle Settings
  • Stores middleClickAction in barConfigs (default "none", zero regression)
  • BarCanvas MouseArea branches on middle button and dispatches the configured action
  • Left/right click behavior unchanged (still dismisses popouts/menus)

Description

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Screenshots / video

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

- New per-bar "Middle Click" setting in DankBar Settings (SettingsDropdownRow)
- Options: None / Toggle Control Center / Toggle Launcher / Close Active Window / Toggle Settings
- Stores middleClickAction in barConfigs (default "none", zero regression)
- BarCanvas MouseArea branches on middle button and dispatches the configured action
- Left/right click behavior unchanged (still dismisses popouts/menus)
barWindow.triggerControlCenter();
return;
case "spotlight":
Quickshell.execDetached(["dms", "ipc", "call", "spotlight", "toggle"]);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldnt execute dms ipc from within DMS itself, should use PopoutService, e.g. PopoutService.toggleDankLauncherV2()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants