fix: serde and packable on empty

[benesjan]

Fixes #17586

Forgot to handle the empty struct case when implementing the derivation functionality. This PR fixes it.

[benesjan]

• fix: serde and packable on empty #18584 👈 (View in Graphite)
• next

This stack of pull requests is managed by Graphite. Learn more about stacking.

[AztecBot]

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033[38;2;188;109;208mFLAKED\033[0m (\033[38;2;250;217;121m8;;http://ci.aztec-labs.com/3aef50d5b0c415c5�3aef50d5b0c415c58;;�\033[0m): yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_multi_proof.test.ts (162s) (code: 1) group:e2e-p2p-epoch-flakes (\033[38;2;188;109;208mJan Beneš\033[0m: fix: serde and packable on empty (#18584))

[mverzilli]

Always a pleasure to review a one file PR :D

Only comment is we seem to be checking multiple times the same cases (params>1, params==1, params==0) so it would be nice to reduce that duplication, but I'm not sure whether that's possible in Noir and more specifically in Noir macros

[benesjan]

Only comment is we seem to be checking multiple times the same cases

Yes, there is a large overlap between serde and packable. I think we had a plan to eventually merge the Serialize and Deserialize traits into one trait and at that point they would become even more similar. So would wait until we do that to bother with this.