fix: fixing repodepot support for azlinux3 and ubuntu2404 as well as PMC on Ubuntu #7565
Conversation
… and all AzLinux version.
djsly
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
| cloud-init status --wait | ||
|
|
||
| function init_mariner_repo_depot { | ||
| local repodepot_endpoint=$1 |
There was a problem hiding this comment.
is this copied from somewhere? Can you please add the source?
| IS_MARINER=1 | ||
| elif [[ $NAME == *"Microsoft Azure Linux"* ]]; then | ||
| IS_AZURELINUX=1 | ||
| else |
There was a problem hiding this comment.
i see that below you have mentioned
no customization
Can we keep the behaviour consistent, like log a error message/warning that we cannot determine the distribution and customization may not be applied. i feel exit 1 is a bit extreme
|
|
||
| cloud-init status --wait | ||
|
|
||
| function init_mariner_repo_depot { |
There was a problem hiding this comment.
Please add documentation of source of this script.
| elif [[ $ID == *"flatcar"* ]]; then | ||
| IS_FLATCAR=1 | ||
| else | ||
| echo "Unknown Linux distribution" |
There was a problem hiding this comment.
same here rather log a warning instead of exit 1
| fi | ||
|
|
||
| if [ "$IS_FLATCAR" -eq 0 ]; then | ||
| function init_ubuntu_main_repo_depot { |
There was a problem hiding this comment.
i feel all the repo depot customizations can be moved to a separate file, its ok to defer to another PR, but seems like lot of code here :(
| # Disable systemd-timesyncd and install chrony and uses local time source | ||
| chrony_conf="/etc/chrony/chrony.conf" | ||
| if [ "$IS_FLATCAR" -eq 0 ]; then | ||
| if [ "$IS_UBUNTU" -eq 1 ]; then |
There was a problem hiding this comment.
Azure linux doesnt require this?
| EOF | ||
|
|
||
| if [ "$IS_FLATCAR" -eq 0 ]; then | ||
| if [ "$IS_UBUNTU" -eq 1 ]; then |
There was a problem hiding this comment.
same here doesnt other OS require it?
What type of PR is this?
/kind bug
What this PR does / why we need it:
fixing repodepot support for azlinux3 and ubuntu2404 as well as PMC on Ubuntu
Requirements:
Special notes for your reviewer:
Release note: