Skip to content

Remove tests that require User-Agent and x-ms-client-request-id override #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antkmsft wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove tests that require User-Agent and x-ms-client-request-id override #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e8778e
Remove tests that require User-Agent and x-ms-client-request-id override
antkmsft Jan 31, 2023
5cf06a9
Update number of missing endpoints
antkmsft Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions legacy/routes/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,7 @@ var header = function (coverage, optionalCoverage) {
optionalCoverage["HeaderParameterProtectedKey"] = 1; // NOT A THING
optionalCoverage["CustomHeaderInRequest"] = 0;
router.post("/param/:scenario", function (req, res, next) {
if (req.params.scenario === "existingkey") {
if (req.get("User-Agent") === "overwrite") {
coverage["HeaderParameterExistingKey"]++;
res.status(200).end();
} else {
utils.send400(
res,
next,
'Did not like scenario "' + req.params.scenario + '" with value ' + req.get("User-Agent"),
);
}
} else if (req.params.scenario === "protectedkey") {
if (req.params.scenario === "protectedkey") {
//We are making this change in the test server because for data plane we have to support scenarios where the user can override
//the protected header like Content-Type by providing one.
if (req.get("Content-Type") === "text/html") {
Expand All @@ -37,15 +26,6 @@ var header = function (coverage, optionalCoverage) {
}
});

router.post("/custom/x-ms-client-request-id/9C4D50EE-2D56-4CD3-8152-34347DC9F2B0", function (req, res, next) {
if (req.get("x-ms-client-request-id").toLowerCase() === "9C4D50EE-2D56-4CD3-8152-34347DC9F2B0".toLowerCase()) {
optionalCoverage["CustomHeaderInRequest"]++;
res.status(200).end();
} else {
utils.send400(res, next, 'Did not like client request id "' + req.get("x-ms-client-request-id"));
}
});

router.post("/response/:scenario", function (req, res, next) {
if (req.params.scenario === "existingkey") {
coverage["HeaderResponseExistingKey"]++;
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"format": "npm run -s prettier -- --write",
"check-format": "npm run -s prettier -- --check",
"prettier": "prettier --config ./.prettierrc.yml **/*.{ts,js,cjs,mjs,json,yml,yaml,md}",
"validate-spec-coverage": "node ./dist/cli/cli.js validate-spec-coverage --maxErrorCount=77"
"validate-spec-coverage": "node ./dist/cli/cli.js validate-spec-coverage --maxErrorCount=76"
},
"engines": {
"node": ">=10"
Expand Down Expand Up @@ -92,4 +92,4 @@
"xml2js": "^0.4.23",
"yargs": "^17.3.1"
}
}
}
8 changes: 0 additions & 8 deletions swagger/examples/header_paramExistingKey.json
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions swagger/header.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,38 +10,6 @@
"produces": ["application/json"],
"consumes": ["application/json"],
"paths": {
"/header/param/existingkey": {
"post": {
"operationId": "header_paramExistingKey",
"description": "Send a post request with header value \"User-Agent\": \"overwrite\"",
"x-ms-examples": {
"header_paramExistingKey": {
"$ref": "./examples/header_paramExistingKey.json"
}
},
"tags": ["Header Operations"],
"parameters": [
{
"description": "Send a post request with header value \"User-Agent\": \"overwrite\"",
"name": "User-Agent",
"in": "header",
"type": "string",
"required": true
}
],
"responses": {
"200": {
"description": "Empty Response"
},
"default": {
"description": "Unexpected error",
"schema": {
"$ref": "#/definitions/Error"
}
}
}
}
},
"/header/response/existingkey": {
"post": {
"operationId": "header_responseExistingKey",
Expand Down