Sync eng/common directory with azure-sdk-tools for PR 12350 #6865
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools for PR #12350, updating stress testing deployment scripts with cluster naming changes and improved validation logic.
Key changes:
- Updates cluster group names to use the "SSS3PT_" prefix for pg, prod, and storage environments
- Adds validation to detect uncommitted changes to values.yaml and prompts users to use the
-LocalAddonsPathparameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 | Updates cluster group resource names with "SSS3PT_" prefix for three environments (pg, prod, storage) |
| eng/common/scripts/stress-testing/deploy-stress-tests.ps1 | Adds git-based validation to detect local values.yaml changes and require explicit -LocalAddonsPath parameter |
| $clusterGroup = 'SSS3PT_rg-stress-cluster-storage' | ||
| $subscription = 'Azure SDK Test Resources - TME' | ||
| $tenant = '72f988bf-86f1-41af-91ab-2d7cd011db47' | ||
| } elseif (!$clusterGroup -or !$subscription -or $tenant) { |
There was a problem hiding this comment.
Logic error in condition: $tenant should be !$tenant. The current condition (!$clusterGroup -or !$subscription -or $tenant) will evaluate to true when $tenant IS set, which is the opposite of the intended behavior. It should check if $tenant is NOT set.
Suggested change
| } elseif (!$clusterGroup -or !$subscription -or $tenant) { | |
| } elseif (!$clusterGroup -or !$subscription -or !$tenant) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12350 See eng/common workflow