Skip to content

Conversation

@alzimmermsft
Copy link
Member

Description

Fix OpenRewrite tests failing in Java 25 due to missing Java 25-specific recipes. The missing dependency fixes parsing errors due to changes in JDK APIs which were causing a missing method exception being thrown.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Jan 9, 2026
Copilot AI review requested due to automatic review settings January 9, 2026 17:38
@github-actions github-actions bot added the Azure SDK Tools Label for tracking issues related to Azure SDK Tools label Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure:azure-openrewrite

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes OpenRewrite tests failing in Java 25 by updating OpenRewrite from version 3.9.0 to 3.22.0 and adding the Java 25-specific dependency. The update also includes code quality improvements in the test file.

  • OpenRewrite version bump from 3.9.0 to 3.22.0
  • Added rewrite-java-25 test dependency
  • Refactored test code with improved Stream usage and modern Java idioms

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
sdk/tools/azure-openrewrite/pom.xml Updated OpenRewrite BOM version and added rewrite-java-25 dependency
eng/versioning/external_dependencies.txt Updated OpenRewrite version to maintain consistency
sdk/tools/azure-openrewrite/src/test/java/com/azure/openrewrite/migration/FullSampleMigrationTest.java Refactored code with improved Stream operations, diamond operators, better exception handling, added RecordComponents parameter, and fixed typo

@alzimmermsft
Copy link
Member Author

@microsoft-github-policy-service rerun

@alzimmermsft
Copy link
Member Author

/check-enforcer evaluate

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft alzimmermsft merged commit f0e0c24 into Azure:main Jan 9, 2026
37 of 38 checks passed
@alzimmermsft alzimmermsft deleted the FixOpenRewriteTests branch January 9, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure SDK Tools Label for tracking issues related to Azure SDK Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants