fix: InputStreamContent closes caller InputStream between retry attempts by arnabnandy7 · Pull Request #49650 · Azure/azure-sdk-for-java

arnabnandy7 · 2026-06-26T19:39:55Z

Description

This pull request resolves Issue #49648, where InputStreamContent built from a mark/reset-capable InputStream loses replayability after a failed HTTP attempt, causing all subsequent retries to fail with an IOException: Stream closed exception.

Root Cause

When validating the body length of a request, RestProxyUtils wraps the InputStream in a LengthValidatingInputStream. Upon a failed request, the HTTP client/reactive pipeline cleans up resources by calling close() on the wrapped stream. LengthValidatingInputStream.close() was unconditionally delegating the close() call to the underlying user-provided stream, thereby closing it prematurely. On subsequent retries, when the pipeline calls reset() on the wrapped stream, the underlying stream throws a "Stream closed" exception as it has already been closed.

Fix

Updated LengthValidatingInputStream.close() to be a no-op. Since the contract of BinaryData.fromStream(inputStream) guarantees that the Azure SDK does not take ownership or close the user-provided stream (the caller is responsible for its lifecycle), the REST proxy should not close the underlying stream either.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

github-actions · 2026-06-26T19:40:57Z

Thank you for your contribution @arnabnandy7! We will review the pull request and get back to you soon.

Copilot

Pull request overview

Fixes an InputStreamContent retry regression in azure-core where request-body length validation wrapped the caller’s InputStream in LengthValidatingInputStream, and the wrapper’s close() would close the underlying caller stream between retry attempts—breaking mark/reset replayability and causing subsequent retries to fail with IOException: Stream closed.

Changes:

Changed LengthValidatingInputStream.close() to be a no-op to avoid closing the underlying user-provided InputStream between retries.
Added in-code rationale tying the behavior to the BinaryData.fromStream ownership/closure contract.

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Apply Spotless formatting to the strengthened close/reset regression test and remove an accidental duplicate semicolon.

Document caller-owned stream handling in LengthValidatingInputStream, use assertFalse in the close/reset regression test, and revert unrelated UrlBuilder timeout increases.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

fix: InputStreamContent closes caller InputStream between retry attempts

e5d1ed2

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

Copilot AI review requested due to automatic review settings June 26, 2026 19:39

arnabnandy7 requested review from a team, JonathanGiles, alzimmermsft, samvaity, srnagar and vcolin7 as code owners June 26, 2026 19:39

Copilot started reviewing on behalf of arnabnandy7 June 26, 2026 19:40 View session

github-actions Bot added Azure.Core azure-core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jun 26, 2026

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread ...-core/src/main/java/com/azure/core/implementation/http/rest/LengthValidatingInputStream.java

[core] Add unit test for LengthValidatingInputStream close behavior

40b38d6

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

arnabnandy7 requested a review from Copilot June 26, 2026 19:54

Copilot started reviewing on behalf of arnabnandy7 June 26, 2026 19:55 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread ...re/azure-core/src/test/java/com/azure/core/implementation/http/rest/RestProxyUtilsTests.java

Potential fix for pull request finding

d5ff1a2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

arnabnandy7 requested a review from Copilot June 26, 2026 20:01

Copilot started reviewing on behalf of arnabnandy7 June 26, 2026 20:03 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread ...re/azure-core/src/test/java/com/azure/core/implementation/http/rest/RestProxyUtilsTests.java Outdated

Comment thread ...-core/src/main/java/com/azure/core/implementation/http/rest/LengthValidatingInputStream.java Outdated

arnabnandy7 and others added 2 commits June 27, 2026 01:41

Potential fix for pull request finding

9cb4ce5

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

[core] Add CHANGELOG entry for LengthValidatingInputStream bug fix

c936284

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

arnabnandy7 requested a review from Copilot June 26, 2026 20:30

Copilot started reviewing on behalf of arnabnandy7 June 26, 2026 20:31 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread ...re/azure-core/src/test/java/com/azure/core/implementation/http/rest/RestProxyUtilsTests.java Outdated

Comment thread sdk/core/azure-core/CHANGELOG.md Outdated

arnabnandy7 and others added 2 commits June 27, 2026 02:04

Potential fix for pull request finding

c909ffd

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

[core] Update CHANGELOG and resolve flakiness in UrlBuilderTests

6d852c0

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>

arnabnandy7 requested a review from Copilot June 26, 2026 20:41

Copilot started reviewing on behalf of arnabnandy7 June 26, 2026 20:42 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Merge branch 'main' into fix/stream-closed-retry

b9b6a9e

arnabnandy7 requested a review from Copilot June 27, 2026 11:03

Copilot started reviewing on behalf of arnabnandy7 June 27, 2026 11:03 View session

Copilot AI reviewed Jun 27, 2026

View reviewed changes

Adhered to all the review comments from copilot

c705ea0

arnabnandy7 requested a review from Copilot June 27, 2026 11:19

Copilot started reviewing on behalf of arnabnandy7 June 27, 2026 11:19 View session

Copilot AI reviewed Jun 27, 2026

View reviewed changes

Review fixes

d86ff46

arnabnandy7 requested a review from Copilot June 27, 2026 12:23

Copilot started reviewing on behalf of arnabnandy7 June 27, 2026 12:24 View session

Copilot AI reviewed Jun 27, 2026

View reviewed changes

arnabnandy7 added 2 commits June 27, 2026 18:18

Fix RestProxyUtilsTests formatting

c2591a0

Apply Spotless formatting to the strengthened close/reset regression test and remove an accidental duplicate semicolon.

Address latest stream retry review comments

2f36e12

Document caller-owned stream handling in LengthValidatingInputStream, use assertFalse in the close/reset regression test, and revert unrelated UrlBuilder timeout increases.

arnabnandy7 requested a review from Copilot June 27, 2026 12:54

Copilot started reviewing on behalf of arnabnandy7 June 27, 2026 12:54 View session

Copilot AI reviewed Jun 27, 2026

View reviewed changes

Comment thread ...-core/src/main/java/com/azure/core/implementation/http/rest/LengthValidatingInputStream.java

Removed unnecessary exception

a16b249

arnabnandy7 requested a review from Copilot June 27, 2026 13:16

Copilot started reviewing on behalf of arnabnandy7 June 27, 2026 13:17 View session

Copilot AI reviewed Jun 27, 2026

View reviewed changes

Uh oh!

Conversation

arnabnandy7 commented Jun 26, 2026

Description

Root Cause

Fix

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants