Add cosmos integrate-tests skills#49652
Open
xinlian12 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a package-specific Copilot skill under sdk/cosmos/azure-cosmos intended to document how to run azure-cosmos integration/customer-workflow tests locally in a CI-equivalent way.
Changes:
- Introduces a new
cosmos-run-integration-testsskill with step-by-step Maven commands for building and running failsafe-based integration tests. - Documents profile → group → suite mappings for customer-workflow test profiles and required account configuration inputs.
- Links the documented workflow back to the CI pipeline configuration as a reference point.
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/.github/skills/cosmos-run-integration-tests/SKILL.md | New skill doc describing CI-equivalent local execution of Cosmos integration/customer-workflow tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 9
- Review effort level: Low
| | `ACCOUNT_CONSISTENCY` | CI passes `Session` for these profiles; defaults to `Strong` if unset | | ||
|
|
||
| ## Notes | ||
| - `javaModulesSurefireArgLine` (azure-cosmos-tests/pom.xml) is the **runtime** `--add-opens` block |
Member
Author
There was a problem hiding this comment.
Fixed in 76f846a. The note now points to sdk/cosmos/azure-cosmos-tests/pom.xml.
| ```powershell | ||
| mvn --batch-mode --fail-at-end '-DskipTests' '-Dgpg.skip=true' '-Dmaven.javadoc.skip=true' ` | ||
| '-Dcodesnippet.skip=true' '-Dspotbugs.skip=true' '-Dcheckstyle.skip=true' '-Drevapi.skip=true' ` | ||
| '-Dspotless.apply.skip=true' '-Dspotless.check.skip=true' '-Djacoco.skip=true' '-Denforcer.skip=true' ` |
Member
Author
There was a problem hiding this comment.
Intentionally keeping -Denforcer.skip=true. This skill's goal is to reproduce the cosmos test run quickly, not a byte-for-byte CI build, so it carries a few local-convenience flags CI doesn't. 76f846a adds a Notes bullet making that explicit and tells readers to drop -Denforcer.skip=true if they want CI's enforcer checks locally.
…discovery Place the cosmos-run-integration-tests skill at sdk/cosmos/azure-cosmos-tests/.github/skills/cosmos-run-integration-tests/SKILL.md. The find-package-skill discovery utility inspects only the .github/skills/ directory of the exact package being changed; it does not walk up to the service root or scan sibling packages. azure-cosmos and azure-cosmos-tests are sibling Maven modules, and the skill documents how to run the integration tests that live entirely in azure-cosmos-tests (profiles, testng suites, env vars, and the -pl azure-cosmos-tests verify commands). In the typical workflow (change azure-cosmos, add tests in azure-cosmos-tests, then run them) the agent is in azure-cosmos-tests exactly when it needs this knowledge, so this is the most discoverable home. The directory name matches the frontmatter 'name' field as required by vally lint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3ce8627 to
e4446b4
Compare
…e paths - Reframe the 'use JDK 21' requirement to 'use the same JDK for build (step 1) and test (step 2)'. Step 2 skips compilation, so it runs the classes step 1 installed; mixing JDKs is what causes the class-file version mismatch. Don't hard-code 21 (CI's JavaTestVersion is now 1.25) and make JAVA_HOME illustrative. - Reference JavaTestVersion (globals.yml) instead of a fixed JDK version. - Fix step 2 -pl to the com.azure:azure-cosmos-tests coordinate so it works from the repo root (matches step 1). - Prefix report/pom.xml references with sdk/cosmos/ so paths resolve from root. - Keep the local-convenience flags (e.g. -Denforcer.skip=true) but note they are intentional local deviations, not a byte-for-byte CI build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cosmos integration tests skills