feat. add unified schema to save/load mission save

[nivcoo]

Hello,

I would add new datas on saved file like : start-member-count but all missions had his own scehma, i unified all, actually i did changes only for BlockMissions to check with you if SSB code is OK and after i will do same for all type.

I deprecated old one, and make sure that it still works.

[nivcoo]

Linked to BG-Software-LLC/SuperiorSkyblock2-Missions#2

[nivcoo]

Of course old data still read as before and migrate to new format on next save

[OmerBenGera]

I don't understand.
You can save into the section whatever you want in the mission.
What's the purpose of making all missions save data in the same scheme?

[nivcoo]

I want to implement feature like : Add amount per member for all mission, and with another option to based the amount on the number of member when the mission start, but actually we can't, maybe we can for BlockMissions because you use "counts" name but all other use different schema, so it will not possible to do that

[nivcoo]

For theses mission for exemple, with this format, how can i add value like : start-member-count

[nivcoo]

With my changes, all missions saves will be migrated automaticaly with the new format, that mean in 1 year or 2, you will remove old migrated methods and deprecated one

[OmerBenGera]

I want to implement feature like : Add amount per member for all mission, and with another option to based the amount on the number of member when the mission start, but actually we can't, maybe we can for BlockMissions because you use "counts" name but all other use different schema, so it will not possible to do that

I dont understand what it has to do with the way missions progress is saves into a file
Give me a better deacription of the issue, what this PR fixes, etc.

[nivcoo]

So,

I want to add the feature : per-member-add-amount, like that we will be able to add more difficulty if there is more member in island, but players aren't stupid, if we don't add protection they will just farm with 8 players until the amount of 1 player in island and just leave to have rewards and join after, to protect that i want to add an option in same quest to choose if we what to use the start-members-count, like that even if player leave the amount required will be the same as before, but to do that i need to save this variable somewhere, and actually i can't due to the way the datas are saved

[OmerBenGera]

So,

I want to add the feature : per-member-add-amount, like that we will be able to add more difficulty if there is more member in island, but players aren't stupid, if we don't add protection they will just farm with 8 players until the amount of 1 player in island and just leave to have rewards and join after, to protect that i want to add an option in same quest to choose if we what to use the start-members-count, like that even if player leave the amount required will be the same as before, but to do that i need to save this variable somewhere, and actually i can't due to the way the datas are saved

You can save into the YAML of missions whatever you want, however you want, and load it later however you want.

[nivcoo]

No you don't understand, look my previous images, how can i save : start-member-count ?

start-member-count isn't a requirement, it's a value that change depending on island member number, and after the calculation of required amount will be based on that, currently I am not able to save any extra datas on quetes due to that, is it more clear now ? Thanks

[nivcoo]

I want to be able to create a quests that requirement will be variable depends on the member count of the island, and add anbother option to save into progression file the member count on start of mission to use that and not current island member count to avoid problem like player will leave to have less amount of block break etc

[nivcoo]

And it's not to create external mission, it's to edit current mission type to support the "per_membercount" feature

[OmerBenGera]

You'll need a custom mission jar for that, as the missions track progress per player / per island, regardless of the amount of island members in the island.
This has nothing to do with the way missions save their data.

[nivcoo]

Why custom mission for that ? It's just a new feature for all mission that I want to add, if not i've to dupe all misison type and change the way the datas is saved, and other users will not have this feature so

[nivcoo]

My goal is :

Edit all default mission type, to support the per-member-amount feature, but to do that i have to unified the way the quest progress is actually saved, that's why I PR this, to unified the datas and migrate old format, and after add the new feature in another PR

[nivcoo]

You are right i can juste create custom jar but if I do that the feature will not be available in default missions types

[OmerBenGera]

My goal is :

Edit all default mission type, to support the per-member-amount feature, but to do that i have to unified the way the quest progress is actually saved, that's why I PR this, to unified the datas and migrate old format, and after add the new feature in another PR

I really dont see why you need to change the way missions are saved in order to add that feature.
Even if it is needed, just make the PR and edit all missions so they save the data differently.

[OmerBenGera]

You are right i can juste create custom jar but if I do that the feature will not be available in default missions types

This PR doesnt add this feature neither...

[nivcoo]

The pr doesn’t add feature because I’m waiting this before add the feature, just actually all mission has different saved method, it’s a harder work to edit it one by one, I will have to do but with unified schema

[nivcoo]

If I don’t have it say me how can I say member-start-count for fishing mission so ?

[nivcoo]

My PR is just here to provide a way to save datas in unified way and to add the possiblity to add extra datas without problem too, i will do the PR after to add my feature, but my feature require a rewrite of all mission saved file too, so do you not accept a way to provides for external/internal quests type unified schema but accept if i just edit a migrate old datas for all mission categories ? I don't understand ?

[nivcoo]

And with that all internal mission will use a standard schema, i don't say that my solution is the best but, actually i have to add 1 variable into progress file and i can't, i juste can maybe for Block mission, but not for the others :/

[OmerBenGera]

If I don’t have it say me how can I say member-start-count for fishing mission so ?

In the saveProgress method:
section.set("member-start-count", );

Then in loadProgress method:
section.get("member-start-count");

Its a yaml file, save there whatever you want

[nivcoo]

No i can't do that look my screen,

how can i add this variable here ?

[nivcoo]

That's i the problem, I can save the variable only for blocks mission because the counts is under "counts" section, others mission the list is under island UUID

[OmerBenGera]

No i can't do that look my screen, how can i add this variable here ?

Above the uuid?
You can also create a new section for each island, if thats what you need.
Again, this is a yaml file, save in it whatever you want.

[OmerBenGera]

That's i the problem, I can save the variable only for blocks mission because the counts is under "counts" section, others mission the list is under island UUID

Just make a section for your own data...

[nivcoo]

Yes so save 2 times the uuid thats why its not the best things

[nivcoo]

I just tried to find the best way to save it without dupe the datas

[OmerBenGera]

Yes so save 2 times the uuid thats why its not the best things

Then use:
section.set(uuid + ".member-start-count", );

[nivcoo]

Yes so save 2 times the uuid thats why its not the best things

Then use: section.set(uuid + ".member-start-count", );

But it will break the list '0' '1' etc no ?