Conversation
Start of milestone changes for 8.1
…enericImmutableDummyObjects Correctly set concrete generic type for immutable objects
…OrderReducedToWarning Reduce status from error to warning for attributes in order check
…ersions Allow newer versions of .NET in project compliance check
adecler
requested review from
FraserGreenroyd,
IsakNaslundBh and
al-fisher
as code owners
Fix code compliance on oM
… on IsValidCreateMethod
Instead of explicitly checking some specific folder and specific indices simply loop backwards from the filename to the create folder and check if one of the paths is a match. Avoid the copy pasting of regex, and constant index out of bounds exceptions being thrown.
…ncompleteComplianceChecks Tweaks to compliance checks to handle edge cases
IsakNaslundBh
left a comment
IsakNaslundBh
left a comment
There was a problem hiding this comment.
Happy with the changes in this PR. Code already in use on the Bot, and tests functioning as expected.
Some additional pre-exiting issues found, and PRs raised for them to be incorporated after the 8.1 release:
#510
#512
#512 is relating to the current compliance failure on this PR. Believe fine to dispensate this the check for this PR, as a fix is on the way, and problem kown. Happy to approve.
|
FAO: @adecler @pawelbaran @IsakNaslundBh The check they wish to have dispensation on is project-compliance. If you are providing dispensation on this occasion, please reply with:
|
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 39153284209 |
|
@IsakNaslundBh I have now provided a passing check on reference |
4 participants
Test_Toolkit
Feature
Bug
Compliance