-
Notifications
You must be signed in to change notification settings - Fork 231
[WIP] Polymorphic PC #6374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
[WIP] Polymorphic PC #6374
Conversation
22d4806 to
3c18fdb
Compare
Would be cleaner if `WarpXParticleContainer` had no purely virtual member functions.
660f741 to
706a11f
Compare
|
|
|
Cool, only one test fails: @roelof-groenewald I am thinking about merging this in the current release cycle. Would you be able to potentially help me by running your own GPU tests against this branch, to make sure I do not break any of your Python GPU usage? |
Sure! By when do you want to push the new release? (in other words by when should I have this tested?) |
|
I think I can give you a heads up some time next week to test this :) |
## Summary Add the `Allocator` template, so we can use this with polymorphic PCs (and generally any PC that does not use the default allocator). ## Additional background BLAST-WarpX/warpx#6374 ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
setArena, updatedefine()calls, etc.PinnedMemoryParticleContainer): ifWarpXParticleContainerhad not purely virtual functions, this would be cleaner to implement (adding aWarpXParticleContainer::Basefor now).PC::make_alike<Allocator>Change Default AMReX-Codes/amrex#4771 and simplifymake_alikecalls, and ParticleContainerToBlueprint: Allocator AMReX-Codes/amrex#4776