Repository navigation

Canvas: unforgeable native instance branding (Path2D/Gradient/Image) - #1844

Closed

bkaradzic-microsoft wants to merge 12 commits into

BabylonJS:masterfrom

bkaradzic-microsoft:canvas-path2d-isinstance

Commits on Oct 5, 2026
- Canvas: reject non-Path2D arguments instead of unwrapping them
  
  bkaradzic
  authored and
  bkaradzic-microsoft
  committed
  70d24a9
- Do not assert the thrown error type, and split addPath's arity check
  
  bkaradzic
  authored and
  bkaradzic-microsoft
  committed
  a51a2a1
- Make the Path2D and gradient type checks unforgeable
  
  bkaradzic
  authored and
  bkaradzic-microsoft
  committed
  a408eab
- Canvas: brand native instances instead of unwrapping unchecked objects
  
  authored and
  bkaradzic-microsoft
  committed
  e4a2f03
- Canvas: brand Image and reject unsafe drawImage unwraps
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  7adaab0
- Canvas: tighten branding PR (non-enumerable brand, trim comments)
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  8d07635
- Restore NativeCanvasImage::TryUnwrap declaration and fix ctor indent.
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  80ece47
- Fix over-indented NativeInstanceRegistry::Add in Gradient/Path2D ctors.
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  acf34a2
- Avoid Napi::PropertyDescriptor in NativeInstanceRegistry (UWP/JSI).
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  41528cc
- Canvas: accept string-convertible fill rules
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  76f5171
- Canvas: define native brands portably
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  771b6fa
- Canvas: brand native Canvas sources before drawImage
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  0c28cb8

Navigation Menu

Repository navigation

Canvas: unforgeable native instance branding (Path2D/Gradient/Image) - #1844

Canvas: unforgeable native instance branding (Path2D/Gradient/Image)#1844
bkaradzic-microsoft wants to merge 12 commits into
BabylonJS:masterfrom
bkaradzic-microsoft:canvas-path2d-isinstance

Commits on Oct 5, 2026

Canvas: reject non-Path2D arguments instead of unwrapping them

Do not assert the thrown error type, and split addPath's arity check

Make the Path2D and gradient type checks unforgeable

Canvas: brand native instances instead of unwrapping unchecked objects

Canvas: brand Image and reject unsafe drawImage unwraps

Canvas: tighten branding PR (non-enumerable brand, trim comments)

Restore NativeCanvasImage::TryUnwrap declaration and fix ctor indent.

Fix over-indented NativeInstanceRegistry::Add in Gradient/Path2D ctors.

Avoid Napi::PropertyDescriptor in NativeInstanceRegistry (UWP/JSI).

Canvas: accept string-convertible fill rules

Canvas: define native brands portably

Canvas: brand native Canvas sources before drawImage