Skip to content

Canvas: text metrics, multi-GUI filters, drawImage(canvas), toDataURL #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkaradzic-microsoft merged 16 commits into from
Sep 16, 2026
Merged

Canvas: text metrics, multi-GUI filters, drawImage(canvas), toDataURL #1855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5dc0edc
Canvas: text metrics, multi-GUI filters, drawImage(canvas), toDataURL
bkaradzic-microsoft Aug 28, 2026
2938fe6
Canvas: fix GCC filterstack nested Uniforms default-init
bkaradzic-microsoft Aug 28, 2026
6deda95
Canvas: GPU framebuffer readback for toDataURL and drawImage(canvas)
bkaradzic-microsoft Aug 28, 2026
8ffc000
Canvas: regenerate native-canvas.png golden for em-scale text fix
bkaradzic-microsoft Aug 28, 2026
1e0bcd5
Canvas: address Copilot review on readback alpha and text metrics
bkaradzic-microsoft Aug 28, 2026
6a17cae
Canvas: update CaptureRGBA blit to TextureRegion API after bgfx bump.
bkaradzic-microsoft Sep 1, 2026
ac9e8a4
Guard NanoVG bgfx destroys with isValid on context dispose.
bkaradzic-microsoft Sep 2, 2026
6283216
Initialize NanoVG bgfx handles to BGFX_INVALID_HANDLE after zero-init.
bkaradzic-microsoft Sep 2, 2026
0be41b6
Fix Canvas readback lifetime and drawImage rectangle semantics
bkaradzic Sep 14, 2026
ba8ec74
Fix Canvas readback and text metric edge cases
bkaradzic-microsoft Sep 14, 2026
8b7d19b
Preserve NanoVG texture IDs across backends
bkaradzic-microsoft Sep 15, 2026
253cf30
Skip Canvas pixel tests on the no-op renderer
Sep 15, 2026
2379eb3
Remove private bgfx dependency from installed test sources
bkaradzic-microsoft Sep 15, 2026
ea74274
Address Canvas readback and drawImage review feedback
bkaradzic-microsoft Sep 15, 2026
60c8972
Fix untouched Canvas readback and retain drawImage source kind
bkaradzic-microsoft Sep 15, 2026
af07833
Encode only written PNG bytes in Canvas data URLs
bkaradzic-microsoft Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified Apps/Playground/ReferenceImages/native-canvas.png
View file
Open in desktop
Comment thread
bkaradzic-microsoft marked this conversation as resolved.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions Apps/UnitTests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ set_source_files_properties(${TEST_SCRIPTS} PROPERTIES HEADER_FILE_ONLY TRUE)
set(SOURCES
"Source/App.h"
"Source/App.cpp"
"Source/Tests.Canvas.TextMetrics.cpp"
"Source/Tests.Canvas.Readback.cpp"
"Source/Tests.Device.FrameEncoder.cpp"
"Source/Tests.ExternalTexture.cpp"
"Source/Tests.ExternalTexture.Lifecycle.cpp"
Expand Down Expand Up @@ -73,6 +75,8 @@ endif()

add_executable(UnitTests ${BABYLONJS_ASSETS} ${BABYLONJS_MATERIALS_ASSETS} ${TEST_ASSETS} ${TEST_SCRIPTS} ${SOURCES})
target_include_directories(UnitTests PRIVATE "${CMAKE_CURRENT_SOURCE_DIR}/../../Plugins/NativeEngine/Source")
target_include_directories(UnitTests PRIVATE "${BGFX_DIR}/3rdparty")
target_compile_definitions(UnitTests PRIVATE CANVAS_TEST_FONT_PATH="${BGFX_DIR}/examples/runtime/font/droidsans.ttf")
target_link_libraries(UnitTests
PRIVATE AppRuntime
PRIVATE Blob
Expand Down
692 changes: 669 additions & 23 deletions Apps/UnitTests/JavaScript/dist/tests.javaScript.all.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading