Repository navigation
Address cube, validation, and Meshopt review follow-ups - #1910
Open
bkaradzic-microsoft wants to merge 2 commits into
Open
bkaradzic-microsoft wants to merge 2 commits into
bkaradzic-microsoft wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 2
Open (6)
colorTextures. Ifsamples > 1and… · Newseen[id]) can collide with inherited keys (e.g.,__proto__) and… · New
What changed in this PR
Follow-up changes addressing prior review feedback around cube render targets, native validation readiness/convergence logic, and Meshopt export documentation.
Changes:
- Reject multisampled cube render targets and ensure cube render-target faces are zero-initialized.
- Make native validation convergence time-based (60s) and broaden readiness checks across render passes / cameras / utility layers.
- Clarify
_native.decodeMeshoptas a compatibility export in code comments/docs.
| File | Description |
|---|---|
| Plugins/NativeMeshopt/Source/NativeMeshopt.cpp | Updates comments clarifying decodeMeshopt as a compatibility export. |
| Plugins/NativeMeshopt/README.md | Updates documentation of the compatibility entry point behavior/usage. |
| Plugins/NativeMeshopt/Include/Babylon/Plugins/NativeMeshopt.h | Updates header comments to match current Babylon.js Meshopt behavior. |
| Plugins/NativeEngine/Source/NativeEngine.cpp | Adds explicit rejection of multisampled cube render targets during init and framebuffer creation. |
| Documentation/AddingNewValidationTests.md | Updates guidance to reflect new convergence and render-pass readiness behavior. |
| Core/Graphics/Source/Texture.cpp | Zero-fills cube RT memory on creation to match WebGL semantics. |
| Apps/UnitTests/Source/Tests.NativeEngine.CubeRenderTargets.cpp | Adds a unit test for multisample rejection + zero-fill behavior. |
| Apps/Playground/Scripts/validation_native.js | Reworks convergence logic and render-pass enumeration; adds scheduling self-check. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bkaradzic-microsoft
requested review from
bghgary
and
a balanced review from Copilot
October 2, 2026 01:04
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 2
Open (3)
hasPassIdcurrently treats any non-null/undefined value (includingNaN, objects, and strings)… · NewdepthStencilTextureattachment is not covered by the… · New
Resolved since last review (6)
colorTextures. Ifsamples > 1and…seen[id]) can collide with inherited keys (e.g.,__proto__) and…
bkaradzic-microsoft
force-pushed
the
pr/review-followups
branch
from
October 5, 2026 19:28
8d03a0d to
feb0a00
Compare
Reject multisampled cube render targets instead of creating framebuffers that read back as zeros. Zero-fill cube render-target faces to match WebGL texImage2D(null), and read them before any clear. Bound validation convergence by elapsed time, inspect every render pass the next frame can use, and enroll only utility layers that render automatically. Poll every associated scene before combining readiness. Describe decodeMeshopt as a compatibility export that pinned Babylon.js 9.21.2 and current MeshoptCompression do not consume. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e6c3c123-c355-4790-a3d4-94337ed6e052
Fail the cube readback test if the promise is not fulfilled within 30 seconds. Reject a multisampled cube used as the depth attachment as well as a color attachment. Deduplicate render passes with a Set, and report scheduling self-check failures without aborting the validation suite. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e6c3c123-c355-4790-a3d4-94337ed6e052
bkaradzic-microsoft
force-pushed
the
pr/review-followups
branch
from
October 7, 2026 05:04
feb0a00 to
53e2e6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for review comments on #1885, #1890, and #1897, rebased onto
3428526fafter #1913 merged._native.decodeMeshoptis a compatibility export unused by stock Babylon.js.Preserves the newer texture-layer validation, Draco isolation, and GUI readiness fixes from #1913. Windows V8/D3D11: all 371 enabled validation scenes pass, along with 12 cube/texture regressions and the scheduling self-check. No reference, tolerance, exclusion, or CI changes.