Merged
Conversation
Fixes #229. The npm package previously shipped no type definitions, forcing TypeScript consumers to write their own declare module shims. Changes: - Added build:types step (tools/bundle-dts.js) that auto-generates a bundled dist/spector.d.ts from the .d.ts files ts-loader already emits during the webpack build — zero new dependencies - Added 'types' field to package.json pointing to dist/spector.d.ts - Added dist/spector.d.ts to the 'files' array so npm publish includes it - Added skipLibCheck to tsconfig for third-party type compatibility Consumers can now use: import { Spector, ICapture, Observable } from 'spectorjs'; import * as SPECTOR from 'spectorjs'; Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sebavan
added a commit
that referenced
this pull request
Mar 30, 2026
…aster Merges origin/master (PRs #338 feat/react, #339 typescript) into feat/offscreen. Conflict resolutions: - spector.ts: keep React imports + WorkerBridge import + SCSS imports - captureMenu.ts: accept deletion (replaced by React), port addCanvasInformation() to ReactCaptureMenu - package.json: merge all scripts (build:types, worker bundle, jest, playwright), keep both dep sets - .gitignore: keep both test-results/ and playwright-report/ - Build artifacts: rebuilt from merged source ReactCaptureMenu now supports Worker OffscreenCanvas entries via addCanvasInformation() with persistent extra entries that survive DOM canvas list refreshes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #229