fix net10 build: comparison with string and int that worked until now #1634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Building on net10 failed because the build script tried comparing the major version
"10"(a string) with9(an integer). I haven't checked how string/int comparisons work exactly, but"9" -ge 9isTrue, but"10" -ge 9isFalse. The script would wrongly find that net10 isn't able to build for any version of the framework and fail.This patch just converts it to an integer.
Using: