Fix RestrictedEvalProvider to retain state and print#686
Open
datvo06 wants to merge 1 commit into
Open
Conversation
Closes #685. Two defects in `RestrictedEvalProvider.exec`, fine for single-shot synthesis decoding but breaking any caller that reuses the namespace across calls (e.g. a persistent REPL): - Rebinding a name already in the namespace was silently dropped: `keys_before` was snapshotted after `rglobals.update(env)`, so the copy-back only saw never-before-present keys. Replace with an identity diff that copies back every binding effect — new names and rebindings of seeded names alike. - `print(...)` raised `NameError: '_print_'`: RestrictedPython rewrites print into its `_print_` collector protocol, which the provider never supplied. Add `_StdoutPrintCollector`, a `_print_` factory routing output to the real `sys.stdout` so output-capturing callers see it. The `exec` op's contract — after `exec(bytecode, env)`, `env` reflects all top-level binding effects — now holds under both providers. Backward-compatible with the synthesis decode caller (its dict is read once and discarded).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #685