timeout related fixes and error propogation improvements#120
timeout related fixes and error propogation improvements#120amruthesht wants to merge 16 commits into
timeout related fixes and error propogation improvements#120Conversation
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
079696d to
0596e06
Compare
orbeckst
left a comment
There was a problem hiding this comment.
👍 on the timeout=600.
I have technical comments on the tests, please see inline.
@HeydenLabASU do you want to review and give your blessing?
@ljwoods2 do you have comments?
|
@orbeckst super backed up atm, will need ~1 week to get to this. apologies, feel free to move forward without me if you're hoping to push a release |
|
@amruthesht please resolve the conflict that's holding up the CI. Thanks. |
00b7edb to
51dd426
Compare
orbeckst
left a comment
There was a problem hiding this comment.
The refactoring of the client/server in the tests looks good to me (and all tests continue to pass).
Coverage is low because you added many more cases for exceptions and we're not testing all these different fail cases separately. There also appears to be some code (InThread client?) that is not really tested at all (?)
I don't think it's worthwhile right now to create test cases for each separate failure case (unless it's easy to do, e.g. with mocking) but we should be clear what is untested code. Could you please
- check the [coverage]((https://app.codecov.io/gh/Becksteinlab/imdclient/pull/120) for the code.
- mark untested code blocks with
#pragma: nocover - raise issues for larger code blocks that should be tested eventually
|
@amruthesht @HeydenLabASU I think we still want this fix, right? |
|
@amruthesht can you finish the PR and then we can make a release #130? We need a release so that we have a zenodo DOI for the package as we want to include that in the paper. |
- added new tests for `wait_for_space` and `_await_IMD_handshake` - restrcuture TestBaseIMDProducer tests into TestIMDClientV3
|
@orbeckst, I added additional tests to improve coverage and restructured some of the test classes. I think the PR would add useful fixes and error handling to the package |
orbeckst
left a comment
There was a problem hiding this comment.
Thanks for adding the additional tests.
Last thing: please add an entry to CHANGELOG!
|
@amruthesht as discussed, we only need the CHANGELOG entry and then it's good to go. |
Fixes #111
Changes made in this Pull Request:
timeoutdefualt value chnaged to600timeouttimeout <= 1PR Checklist