parser: add_schema_from_file: return InvalidFilePath instead of io::Error - #292
Merged
Merged
Conversation
…rror This allows providing the information about the path wihtin the error.
Bergmann89
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to: #291
This is another case where the user would get an
io::Errorwithout any information about the path.With this change, the Error provides the information about the path.
From what I see this was the only use of the implicit conversion from
io::Errorinxsd-parser/xsd-parser/src/pipeline/parser/error.rs
Lines 15 to 18 in aeb9f32
I think it's worth considering to drop the
#[from]for implicit conversion completely, so that the users of this type must explicitly handleio::Errorand produce an error with the path info.