Skip to content

Extract method for feature flag check #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevenjackson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extract method for feature flag check #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/controllers/concerns/test_track/controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,17 @@ module TestTrack::Controller
class_methods do
def require_feature_flag(feature_flag, *args)
before_action(*args) do
raise ActionController::RoutingError, 'Not Found' unless test_track_visitor.ab(feature_flag, context: self.class.name.underscore)
raise ActionController::RoutingError, 'Not Found' unless feature_flagged?(feature_flag)
end
end
end

private

def feature_flagged?(feature_flag)
test_track_visitor.ab(feature_flag, context: self.class.name.underscore)
end

def test_track_session
@test_track_session ||= TestTrack::WebSession.new(self)
end
Expand Down
Loading