Add support for managing organizations in Keycloak #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new `IKcOrganizations` interface and its implementation in `KcOrganizations` to enable CRUD operations, listing, and filtering of organizations in Keycloak. Updated the `IKeycloakClient` and `KeycloakClient` classes to expose the `Organizations` client. Added supporting models: - `KcOrganization` to represent organization resources. - `KcOrganizationDomain` to represent domain information. - `KcOrganizationFilter` to enable filtering options for queries. Updated `NETCore.Keycloak.Client.csproj` to clean up formatting and remove unnecessary metadata files.
hasnimehdi91
requested changes
Jan 12, 2026
Contributor
There was a problem hiding this comment.
- Please fix the documentation to ensure it is accurate, consistent with the existing style, and free of any ambiguities.
- Please investigate and resolve the failing tests so that the full test suite passes successfully before merging.
- Please review and address any security issues related to dependent NuGet packages, including updating vulnerable dependencies and ensuring compatibility.
Contributor
There was a problem hiding this comment.
Please fix the documentation to ensure it is accurate, consistent with the existing style, and free of any ambiguities.
| /// <summary> | ||
| /// Build query string | ||
| /// </summary> | ||
| public new string BuildQuery() |
Contributor
There was a problem hiding this comment.
Please fix the documentation (inline docs) to ensure it is accurate, consistent with the existing style, and free of any ambiguities.
added 2 commits
January 13, 2026 09:57
Updated XML documentation for `KcOrganization`, `KcOrganizationDomain`, and `KcOrganizationFilter` to improve clarity and align with Keycloak API references. Added `<value>` tags for property descriptions. Refactored `KcOrganizationFilter`: - Replaced multiple filtering properties with a generic `Q` property. - Updated `Exact` property to indicate exact match behavior. - Switched from `System.Text.Json` to `Newtonsoft.Json` for serialization. - Rewrote `BuildQuery` for cleaner and more maintainable query string construction. Improved consistency in naming conventions and descriptions across classes. Removed redundant properties and comments. Aligned code structure with Keycloak API standards.
Updated `IKcOrganizations` interface and `KcOrganizations` implementation to enhance XML documentation, align with the latest Keycloak REST API, and improve maintainability. - Added `using` directives for required dependencies in `IKcOrganizations.cs`. - Updated XML documentation for all methods in `IKcOrganizations` to include detailed return type descriptions and exception handling details. - Replaced outdated Keycloak API links in `KcOrganization` and `KcOrganizationDomain` with updated references. - Used `<inheritdoc>` tags in `KcOrganizations` to ensure consistency with the interface and reduce redundancy. - Implemented methods in `KcOrganizations` with improved documentation and alignment with the updated interface.
![codefactor-io[bot]](https://avatars.githubusercontent.com/in/25603?s=60&v=4){kind=small}
| /// </returns> | ||
| public new string BuildQuery() | ||
| { | ||
|
|
There was a problem hiding this comment.
An opening brace should not be followed by a blank line.
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new
IKcOrganizationsinterface and its implementation inKcOrganizationsto enable CRUD operations, listing, and filtering of organizations in Keycloak. Updated theIKeycloakClientandKeycloakClientclasses to expose theOrganizationsclient.Added supporting models:
KcOrganizationto represent organization resources.KcOrganizationDomainto represent domain information.KcOrganizationFilterto enable filtering options for queries.Updated
NETCore.Keycloak.Client.csprojto clean up formatting and remove unnecessary metadata files.